Skip to content

fix(lightspeed): update missing permission illsutration#3261

Open
rohitratannagar wants to merge 2 commits into
redhat-developer:mainfrom
rohitratannagar:fix/lightspeed-missing-permission-image
Open

fix(lightspeed): update missing permission illsutration#3261
rohitratannagar wants to merge 2 commits into
redhat-developer:mainfrom
rohitratannagar:fix/lightspeed-missing-permission-image

Conversation

@rohitratannagar
Copy link
Copy Markdown
Contributor

@rohitratannagar rohitratannagar commented Jun 1, 2026

Summary

Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3152

  • Replaced the old permission-required SVG with the new illustration
  • Replaced Backstage EmptyState with a custom responsive layout using CSS container
    queries
  • In overlay/docked mode (narrow): centered stacked layout with image above text
  • In fullscreen/embedded mode (wide): side-by-side layout with text on left, image on
    right
  • Image and text sizes scale fluidly with available space using clamp() and cqi
    units

UI after changes

Screen.Recording.2026-06-02.at.1.02.02.AM.mov

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Signed-off-by: rohitratannagar <rohitratannagar2003@gmail.com>
@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app Bot commented Jun 1, 2026

Changed Packages

Package Name Package Path Changeset Bump Current Version
app-legacy workspaces/lightspeed/packages/app-legacy none v0.0.27
app workspaces/lightspeed/packages/app none v0.0.26
@red-hat-developer-hub/backstage-plugin-lightspeed workspaces/lightspeed/plugins/lightspeed patch v2.9.0

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.57%. Comparing base (ac69555) to head (8c823bd).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3261      +/-   ##
==========================================
- Coverage   53.57%   53.57%   -0.01%     
==========================================
  Files        2407     2407              
  Lines       86535    86534       -1     
  Branches    23943    23941       -2     
==========================================
- Hits        46361    46360       -1     
  Misses      38692    38692              
  Partials     1482     1482              
Flag Coverage Δ *Carryforward flag
adoption-insights 83.58% <ø> (ø) Carriedforward from 8ffd654
ai-integrations 70.03% <ø> (ø) Carriedforward from 8ffd654
app-defaults 69.60% <ø> (ø) Carriedforward from 8ffd654
augment 46.39% <ø> (ø) Carriedforward from 8ffd654
bulk-import 72.86% <ø> (ø) Carriedforward from 8ffd654
cost-management 16.49% <ø> (ø) Carriedforward from 8ffd654
dcm 45.40% <ø> (ø) Carriedforward from 8ffd654
extensions 61.79% <ø> (ø) Carriedforward from 8ffd654
global-floating-action-button 74.30% <ø> (ø) Carriedforward from 8ffd654
global-header 61.63% <ø> (ø) Carriedforward from 8ffd654
homepage 51.52% <ø> (ø) Carriedforward from 8ffd654
konflux 91.01% <ø> (ø) Carriedforward from 8ffd654
lightspeed 68.33% <ø> (-0.01%) ⬇️
mcp-integrations 85.46% <ø> (ø) Carriedforward from 8ffd654
orchestrator 36.60% <ø> (ø) Carriedforward from 8ffd654
quickstart 62.88% <ø> (ø) Carriedforward from 8ffd654
sandbox 79.56% <ø> (ø) Carriedforward from 8ffd654
scorecard 83.84% <ø> (ø) Carriedforward from 8ffd654
theme 64.54% <ø> (ø) Carriedforward from 8ffd654
translations 8.49% <ø> (ø) Carriedforward from 8ffd654
x2a 78.79% <ø> (ø) Carriedforward from 8ffd654

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac69555...8c823bd. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Playwright < 1.60.0 hangs after browser download on Node 24.16+ during
playwright install in GitHub Actions.

Co-authored-by: Cursor <cursoragent@cursor.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 2, 2026

@rohitratannagar
Copy link
Copy Markdown
Contributor Author

/cc @ShiranHi

Copy link
Copy Markdown
Contributor

@HusneShabbir HusneShabbir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Tested locally, works as expected

Screen.Recording.2026-06-02.at.4.20.48.PM.mov

@HusneShabbir
Copy link
Copy Markdown
Contributor

HusneShabbir commented Jun 2, 2026

@rohitratannagar, the implementation looks a bit different from the Figma design. I’d recommend waiting until @ShiranHi approves the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants