Skip to content

fix(ci): upgrade Playwright to 1.60.0 in e2e workspaces#3267

Merged
jrichter1 merged 2 commits into
redhat-developer:mainfrom
HusneShabbir:fix/ci-upgrade-playwright-1.60.0
Jun 2, 2026
Merged

fix(ci): upgrade Playwright to 1.60.0 in e2e workspaces#3267
jrichter1 merged 2 commits into
redhat-developer:mainfrom
HusneShabbir:fix/ci-upgrade-playwright-1.60.0

Conversation

@HusneShabbir
Copy link
Copy Markdown
Contributor

@HusneShabbir HusneShabbir commented Jun 2, 2026

Summary

Upgrades @playwright/test to 1.60.0 across Playwright e2e workspaces so CI no longer hangs on Node 24.16+ during playwright install (download completes, then extraction stalls on Playwright < 1.60.0).

Workspaces updated

Workspace package.json files updated Lockfile
adoption-insights root, app, app-legacy
bulk-import root, app, app-legacy, plugins/bulk-import
extensions root, app, app-legacy
global-floating-action-button root, app
global-header root, app, app-legacy
quickstart root, app, app-legacy
scorecard root, app-legacy
homepage root, app, app-legacy
theme root, app-legacy

Scope: 25 package.json files and 9 yarn.lock files (34 files). Prior versions (1.58.2, 1.59.1, ^1.56.1, ^1.32.3) are pinned to 1.60.0.

Out of scope: lightspeed — upgrade is handled on a separate PR.

Resolves

https://redhat.atlassian.net/browse/RHIDP-14350

Test plan

  • CI install playwright step completes on Node 24 for affected workspaces
  • No functional e2e changes expected (dependency-only bump)

Prevents playwright install from hanging on Node 24.16+ during zip
extraction after browser download completes.

Updates adoption-insights, bulk-import, extensions,
global-floating-action-button, global-header, homepage, quickstart,
scorecard, and theme. Lightspeed is handled separately.

Co-authored-by: Cursor <cursoragent@cursor.com>
@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app Bot commented Jun 2, 2026

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @red-hat-developer-hub/backstage-plugin-bulk-import

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
app-legacy workspaces/adoption-insights/packages/app-legacy none v0.0.0
app workspaces/adoption-insights/packages/app none v0.0.0
@red-hat-developer-hub/backstage-plugin-bulk-import workspaces/bulk-import/plugins/bulk-import none v7.3.5

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.57%. Comparing base (55e9b9d) to head (e19f8cc).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3267   +/-   ##
=======================================
  Coverage   53.57%   53.57%           
=======================================
  Files        2407     2407           
  Lines       86535    86535           
  Branches    23960    23959    -1     
=======================================
  Hits        46361    46361           
  Misses      38593    38593           
  Partials     1581     1581           
Flag Coverage Δ *Carryforward flag
adoption-insights 83.58% <ø> (ø)
ai-integrations 70.03% <ø> (ø) Carriedforward from fbbceeb
app-defaults 69.60% <ø> (ø) Carriedforward from fbbceeb
augment 46.39% <ø> (ø) Carriedforward from fbbceeb
bulk-import 72.86% <ø> (ø)
cost-management 16.49% <ø> (ø) Carriedforward from fbbceeb
dcm 45.40% <ø> (ø) Carriedforward from fbbceeb
extensions 61.79% <ø> (ø)
global-floating-action-button 74.30% <ø> (ø)
global-header 61.63% <ø> (ø)
homepage 51.52% <ø> (ø)
konflux 91.01% <ø> (ø) Carriedforward from fbbceeb
lightspeed 68.33% <ø> (ø) Carriedforward from fbbceeb
mcp-integrations 85.46% <ø> (ø) Carriedforward from fbbceeb
orchestrator 36.60% <ø> (ø) Carriedforward from fbbceeb
quickstart 62.88% <ø> (ø)
sandbox 79.56% <ø> (ø) Carriedforward from fbbceeb
scorecard 83.84% <ø> (ø)
theme 64.54% <ø> (ø)
translations 8.49% <ø> (ø) Carriedforward from fbbceeb
x2a 78.79% <ø> (ø) Carriedforward from fbbceeb

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e9b9d...e19f8cc. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

A direct playwright@^1.56.1 dependency conflicted with @playwright/test
1.60.0 and caused duplicate lockfile entries and e2e test failures.

Co-authored-by: Cursor <cursoragent@cursor.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 2, 2026

@fullsend-ai-review
Copy link
Copy Markdown

Review

Findings

Medium

  • [incomplete-change] workspaces/x2a/package.json, workspaces/translations/package.json — Two e2e workspaces (x2a and translations) have playwright.config.ts and @playwright/test at older versions (1.59.1 / 1.58.2 at root, ^1.32.3 in sub-packages) but are neither updated by this PR nor listed as intentionally out of scope. The PR body only excludes lightspeed. If the motivation is to fix CI hangs on Node 24.16+ during playwright install, these workspaces will continue to experience the same issue. Either include them in this PR or document why they are excluded.

Low

  • [incomplete-change] workspaces/ — Several additional workspaces (sandbox, repo-tools, augment, orchestrator, cost-management, konflux, ai-integrations, mcp-integrations, app-defaults) also declare @playwright/test at older versions but do not have a playwright.config.ts at their workspace root, making the CI impact less certain. Consider a follow-up PR to align these as well.

Info

  • [pattern-inconsistency] workspaces/global-floating-action-button/package.json — The PR normalizes some caret-ranged entries (^1.56.1, ^1.32.3) to exact pins (1.60.0). This is consistent with the dominant convention for @playwright/test in this repo (exact pinning due to browser binary coupling) and is a positive consistency improvement. Untouched workspaces with caret ranges remain inconsistent.

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Jun 2, 2026
@jrichter1 jrichter1 merged commit 44b418c into redhat-developer:main Jun 2, 2026
105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants