Skip to content

Run instrumented tests with pull requests #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Luna712 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Run instrumented tests with pull requests #2792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99480a9
Run instrumented tests with pull requests
Luna712 May 15, 2026
9d6d320
Merge branch 'recloudstream:master' into run-tests
Luna712 May 29, 2026
d497ba2
Remove
Luna712 Jun 6, 2026
326a6a5
Merge branch 'recloudstream:master' into run-tests
Luna712 Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,50 @@ jobs:
with:
name: pull-request-build
path: "app/build/outputs/apk/prerelease/debug/*.apk"

instrumented-tests:

@fire-light42 fire-light42 Jun 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be heavy CPU/time-wise, but the tests are still extremely valuable in some specific cases (like all of your recent pull requests). Would it be possible to limit these tests to manual-run/tagged/reviewed or something else to prevent running these tests for every single commit in every single pull request? It would simply be a waste otherwise.

@Luna712 Luna712 Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently running the other serializer tests in the emulator fails also, so I need to do some more work to fix that now. I will do so later on. This isn't fully urgent in the meantime, but I will get it done in the next day or two.

@Luna712 Luna712 Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2902 fixed the test failure here also btw.

@Luna712 Luna712 Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fire-light42 also the reason I made instrumentation tests a separate task is to allow ignoring it and not delay actual archive build. I figured it might also be useful like for the layout binding tests for now also, and other things. If you want though I can change its trigger though yeah.

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6

- name: Set up JDK 17
uses: actions/setup-java@v5
with:
distribution: temurin
java-version: 17

- name: Grant execute permission for gradlew
run: chmod +x gradlew

- name: Setup Gradle
uses: gradle/actions/setup-gradle@v5
with:
cache-encryption-key: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
cache-read-only: false

- name: Get target SDK
id: sdk
run: |
TARGET_SDK=$(grep 'targetSdk' gradle/libs.versions.toml | grep -o '[0-9]\+' | head -1)
echo "version=$TARGET_SDK" >> $GITHUB_OUTPUT

- name: Enable KVM
run: |
echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
sudo udevadm control --reload-rules
sudo udevadm trigger --name-match=kvm

- name: Run Instrumented Tests
uses: reactivecircus/android-emulator-runner@v2
with:
api-level: ${{ steps.sdk.outputs.version }}
arch: x86_64
profile: Nexus 6
script: ./gradlew connectedPrereleaseDebugAndroidTest

- name: Upload Test Results
if: always()
uses: actions/upload-artifact@v7
with:
name: instrumented-test-results
path: '**/build/reports/androidTests/'
6 changes: 0 additions & 6 deletions app/src/androidTest/java/com/lagradost/cloudstream3/ExampleInstrumentedTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,6 @@ class ExampleInstrumentedTest {
return APIHolder.allProviders.toTypedArray() //.filter { !it.usesWebView }
}

@Test
fun providersExist() {
Assert.assertTrue(getAllProviders().isNotEmpty())
println("Done providersExist")
}

@Throws
private inline fun <reified T : ViewBinding> testAllLayouts(
activity: Activity,
Expand Down