Run instrumented tests with pull requests#2792
Conversation
| name: pull-request-build | ||
| path: "app/build/outputs/apk/prerelease/debug/*.apk" | ||
|
|
||
| instrumented-tests: |
There was a problem hiding this comment.
This looks to be heavy CPU/time-wise, but the tests are still extremely valuable in some specific cases (like all of your recent pull requests). Would it be possible to limit these tests to manual-run/tagged/reviewed or something else to prevent running these tests for every single commit in every single pull request? It would simply be a waste otherwise.
There was a problem hiding this comment.
Apparently running the other serializer tests in the emulator fails also, so I need to do some more work to fix that now. I will do so later on. This isn't fully urgent in the meantime, but I will get it done in the next day or two.
There was a problem hiding this comment.
#2902 fixed the test failure here also btw.
There was a problem hiding this comment.
@fire-light42 also the reason I made instrumentation tests a separate task is to allow ignoring it and not delay actual archive build. I figured it might also be useful like for the layout binding tests for now also, and other things. If you want though I can change its trigger though yeah.
2 participants
I was originally going to do this in #2791 when adding the test for that but decided it would be better as a separate PR.