Support derived Animate classes in order to use the same axes. - #50
Support derived Animate classes in order to use the same axes.#50tahsinkose wants to merge 1 commit into
Conversation
|
@jhavl this is a rather simple yet capable improvement that provides trivial extensibility of Animate classes. Could you please give it a quick look and merge? 🙏🏼 Cc. @petercorke |
|
Looks great! I'll have a look at the change on the weekend. There's more I'd like to do with animations but this seems like a win. Thx for your interest |
|
@petercorke friendly ping 🙂 |
|
Another friendly ping for @jhavl and @myeatman-bdai. This is rather a simple improvement, thus should not take too much of your time. PTAL 🙏🏼 |
|
@baxelrod-bdai could you check please? It is a pretty small PR |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
petercorke
left a comment
There was a problem hiding this comment.
Really useful small clean fix, embarrassingly long time in approving it.
|
@jbarry-bdai rebased and tested, it passes. |
Hello there,
I've been using the MATLAB version of these nice toolboxes and just recently finally had a use-case to migrate to Python. I needed to visualize multiple frames in a single animation view. In order to do that, I have to derive from

base.animate.Animateand adjust some of the internal data structures. In order to use the sameaxasbase.animate.Animatedoes, however, I had to clone this repo and make this change so that all derived classes receive the exact same treatment with the base class.