Arm backend: Remove statically proven TOSA no-ops

backends/arm/_passes/arm_pass_manager.py

@@ -15,6 +15,7 @@
     AccumulateIndexPutPass,
     BroadcastArgsPass,
     CanonicalizeGatherPass,
+    CanonicalizeViewCopyPermutePass,
     CastInt64BuffersToInt32Pass,
     CastToInt32Pass,
     ComputeConstantOpsAOTPass,
@@ -652,6 +653,10 @@ def _tosa_pipeline(
                 DecomposePermuteForU55Pass(),
                 RewriteSlicePass(),
                 FuseConsecutiveSlicesPass(),
+                # Remove rewritten PAD/SLICE no-ops before cleaning up any
+                # permute pairs they expose.
+                RemoveNoopPass(),
+                CanonicalizeViewCopyPermutePass(),
                 InsertConstShapesPass(),
                 InsertDataLayoutCastsPass(),
             ]

backends/arm/_passes/remove_noop_pass.py

@@ -6,12 +6,13 @@
 
 
 import logging
-from typing import Set, Type
+from typing import Any, Set, Type
 
 from executorch.backends.arm._passes import ArmOpTargetedPass
 
 from executorch.exir.dialects._ops import ops as exir_ops
-from executorch.exir.pass_base import ExportPass
+from executorch.exir.pass_base import ExportPass, PassResult, ProxyValue
+from torch.fx import GraphModule
 
 logger = logging.getLogger(__name__)
 
@@ -20,24 +21,91 @@ class RemoveNoopPass(ArmOpTargetedPass):
     """Remove no-ops from graph_module."""
 
     _passes_required_after: Set[Type[ExportPass]] = set()
+    _single_input_concat_ops = (
+        exir_ops.edge.aten.cat.default,
+        exir_ops.edge.aten.concatenate.default,
+    )
     target_ops = (
         exir_ops.edge.dim_order_ops._clone_dim_order.default,
         exir_ops.edge.dim_order_ops._to_dim_order_copy.default,
         exir_ops.edge.aten.alias_copy.default,
         exir_ops.edge.aten.copy.default,
         exir_ops.edge.aten.detach_copy.default,
+        *_single_input_concat_ops,
+        exir_ops.backend.tosa.PAD.default,
+        exir_ops.backend.tosa.SLICE.default,
     )
 
-    def call_operator(self, op, args, kwargs, meta):
+    @staticmethod
+    def _get_static_shape(value: Any) -> tuple[int, ...] | None:
+        if isinstance(value, ProxyValue):
+            # Shape calculations may carry concrete example values without being
+            # compile-time constants. Only accept explicit CONST_SHAPE nodes.
+            if value.node.target != exir_ops.backend.tosa.CONST_SHAPE.default:
+                return None
+            value = value.data
+
+        # Reject unresolved symbolic dimensions rather than relying on hints.
+        if not isinstance(value, (list, tuple)) or not all(
+            type(dim) is int for dim in value
+        ):
+            return None
+        return tuple(value)
+
+    def call(self, graph_module: GraphModule) -> PassResult:
+        result = super().call(graph_module)
+        # Removing a no-op can leave its shape operands without users.
+        removed_dead_code = result.graph_module.graph.eliminate_dead_code()
+        if removed_dead_code:
+            result.graph_module.graph.lint()
+            result.graph_module.recompile()
+        return PassResult(result.graph_module, result.modified or removed_dead_code)
+
+    def call_operator(self, op, args, kwargs, meta, updated=False):
         if op not in self.target_ops:
-            return super().call_operator(op, args, kwargs, meta)
+            return super().call_operator(op, args, kwargs, meta, updated)
+
+        if op in self._single_input_concat_ops:
+            inputs = args[0]
+            # Concatenating one tensor returns that tensor unchanged.
+            if isinstance(inputs, (list, tuple)) and len(inputs) == 1:
+                return inputs[0]
+            return super().call_operator(op, args, kwargs, meta, updated)
+
+        if op == exir_ops.backend.tosa.PAD.default:
+            padding = self._get_static_shape(args[1])
+            # PAD is an identity when every before/after padding value is zero.
+            if (
+                padding is not None
+                and len(padding) == 2 * len(args[0].data.shape)
+                and all(value == 0 for value in padding)
+            ):
+                return args[0]
+            return super().call_operator(op, args, kwargs, meta, updated)
+
+        if op == exir_ops.backend.tosa.SLICE.default:
+            starts = self._get_static_shape(args[1])
+            sizes = self._get_static_shape(args[2])
+            input_shape = self._get_static_shape(args[0].data.shape)
+            # Starting at zero and selecting the full input shape is an identity.
+            if (
+                starts is not None
+                and sizes is not None
+                and input_shape is not None
+                and starts == (0,) * len(input_shape)
+                and sizes == input_shape
+            ):
+                return args[0]
+            return super().call_operator(op, args, kwargs, meta, updated)
 
         input_dtype = args[0].data.dtype
         output_dtype = kwargs.get("dtype", input_dtype)
 
+        # A clone-like operation that changes dtype is not a no-op.
         if input_dtype != output_dtype:
-            return super().call_operator(op, args, kwargs, meta)
+            return super().call_operator(op, args, kwargs, meta, updated)
 
+        # copy writes its source (args[1]); the remaining targets return args[0].
         if op == exir_ops.edge.aten.copy.default:
             return args[1]
         return args[0]