Arm backend: Remove statically proven TOSA no-ops - #21141
Merged
YufengShi-dudu merged 1 commit intoJul 27, 2026
Conversation
YufengShi-dudu
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21141
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6b31101 with merge base fb5b788 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
YufengShi-dudu
marked this pull request as draft
July 24, 2026 11:32
Remove single-input concatenations, zero-width padding, and full-range slices when their identity behavior is statically proven. Reject unresolved symbolic shapes and eliminate constants left without users. Run cleanup before transpose fusion and before duplicate/output cleanup so newly exposed patterns are simplified safely. TOSA-FP operator counts: | Model | Before | After | Reduction | |----------------------------|-------:|------:|----------:| | Gemma AltUp | 5 | 2 | 3 | | Gemma conformer light-conv | 72 | 67 | 5 | | Qwen3-VL vision attention | 126 | 112 | 14 | | Phi-3 attention | 114 | 112 | 2 | Add positive, negative, symbolic-shape, graph-output, and follow-on cleanup coverage. Change-Id: I915a870d1bea4d27a89293c730e3f9f5f157cd3e Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
YufengShi-dudu
force-pushed
the
extend-remove-noop-pass
branch
from
July 27, 2026 11:47
9540726 to
6b31101
Compare
YufengShi-dudu
marked this pull request as ready for review
July 27, 2026 11:47
freddan80
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove single-input concatenations, zero-width padding, and full-range slices when their identity behavior is statically proven. Reject unresolved symbolic shapes and eliminate constants left without users.
Run cleanup before transpose fusion and before duplicate/output cleanup so newly exposed patterns are simplified safely.
TOSA-FP operator counts:
Add positive, negative, symbolic-shape, graph-output, and follow-on cleanup coverage.
Change-Id: I915a870d1bea4d27a89293c730e3f9f5f157cd3e
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani