Skip to content

fix(exceptions): prevent ErrorTree.__getitem__ from mutating _contents #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
b-wulan wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Draft

fix(exceptions): prevent ErrorTree.__getitem__ from mutating _contents #1490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion jsonschema/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ def __init__(self, errors: Iterable[ValidationError] = ()):
for error in errors:
container = self
for element in error.path:
container = container[element]
container = container._contents[element]
container.errors[error.validator] = error

container._instance = error.instance
Expand All @@ -348,6 +348,8 @@ def __getitem__(self, index):
"""
if self._instance is not _unset and index not in self:
self._instance[index]
if index not in self._contents:
return self.__class__()
return self._contents[index]

def __setitem__(self, index: str | int, value: ErrorTree):
Expand Down
Loading