fix(exceptions): prevent ErrorTree.__getitem__ from mutating _contents#1490
Draft
b-wulan wants to merge 1 commit into
Draft
fix(exceptions): prevent ErrorTree.__getitem__ from mutating _contents#1490b-wulan wants to merge 1 commit into
b-wulan wants to merge 1 commit into
Conversation
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessing
tree[index]on an index with no errors was silently inserting an emptyErrorTreeinto_contentsviadefaultdict, causing subsequent__iter__and__contains__calls to report phantom entries (fixes #1328).The fix has two parts:
__init__now navigates via_contents[element]directly (bypassing__getitem__) to build the tree, and__getitem__returns a fresh detached empty tree when the index is absent rather than triggering the defaultdict factory.To verify: construct a tree with errors only at index 0, access
tree[1], then confirmlist(tree) == [0]and1 not in tree.