fix: custom TOML config files should use [pytest] section, not [tool.pytest]#14711
Closed
fazalpsinfo-cmyk wants to merge 1 commit into
Closed
fix: custom TOML config files should use [pytest] section, not [tool.pytest]#14711fazalpsinfo-cmyk wants to merge 1 commit into
fazalpsinfo-cmyk wants to merge 1 commit into
Conversation
…ction When a custom TOML configuration file is passed via --config-file, the code incorrectly looked for [tool.pytest] section (as used in pyproject.toml). Custom config files should use [pytest] section, matching the behavior of pytest.toml and documented expectations. The else branch was changed to elif filepath.name == 'pyproject.toml' so only pyproject.toml uses [tool.pytest]. A new else branch handles any other custom .toml files by looking for [pytest] table. Fixes pytest-dev#14705
Member
|
Duplicate of #14707 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a custom TOML config file via
-c file.toml, the config loader incorrectly requires[tool.pytest]instead of[pytest]. Onlypyproject.toml(which lives inside a project's tool table) should use the[tool.pytest]path.This fix routes only
pyproject.tomlto the[tool.pytest]section; custom TOML files now correctly use[pytest].Fixes #14705
Support my open source work: https://buymeacoffee.com/muhamedfazalps