Fix custom TOML config files passed with -c#14707
Open
DebadityaHait wants to merge 1 commit into
Open
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14705.
Summary
load_config_dict_from_filepreviously treated every TOML filename other thanpytest.tomland.pytest.tomllikepyproject.toml, so a custom file passed with-cignored its documented[pytest]table.This change reserves
[tool.pytest]and[tool.pytest.ini_options]forpyproject.toml. Other TOML configuration files now read native options from[pytest]. It also adds direct loader and CLI collection regression coverage and documents the custom-file format.Testing
python -m pytest testing/test_findpaths.py testing/test_config.py -q(281 passed, 1 xfailed)pre-commit run --files AUTHORS changelog/14705.bugfix.rst doc/en/reference/customize.rst src/_pytest/config/findpaths.py testing/test_config.py testing/test_findpaths.pysphinx-build -j auto -W --keep-going -b html doc/en doc/en/_build/htmlpytest -c pytest-benchmark.toml --collect-only -qreproduction (1 test collected)