fix: remove duplicate packages/bot, fix remaining build breaks - #944
Open
CSTRSK wants to merge 1 commit into
Open
fix: remove duplicate packages/bot, fix remaining build breaks#944CSTRSK wants to merge 1 commit into
CSTRSK wants to merge 1 commit into
Conversation
…llstack#943) - Delete packages/bot/* (unpublished, unreferenced duplicate of packages/bots/*, zero external consumers) so pnpm -r build no longer compiles the dead tree — fixes the repeated TS2345 failures described in profullstack#943/profullstack#942 - bots/core: annotate finish() with AIResult instead of a widened inline type (TS2345: type string not assignable to "result") - bots/signal: fix outdated test object (groupId undefined→null, drop non-existent raw field, add isGroup)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #943
packages/bot/*is an abandoned, unpublished duplicate ofpackages/bots/*with zero external consumers (the only references are the five packages pointing at each other). It is still compiled bypnpm -r build, so defects there break the workspace build for everyone — exactly what happened in #942.Changes
packages/bot/*entirely (core/discord/signal/telegram/whatsapp — the dead tree). No code references it: no package.json depends on@sh1pt/bot-*, no tsconfig/CI referencespackages/bot.packages/bots/core: annotatefinish()withAIResultinstead of a widened inline type — fixesTS2345: type 'string' not assignable to type '"result"'.packages/bots/signal: fix outdated test object —groupId: undefined → null, drop non-existentrawfield, add requiredisGroup.Verification
pnpm -r build: all packages Done, zero failures (was: bot/core + bots/core + bots/signal failing)tsc -p tsconfig.json --noEmitclean in bots/core and bots/signal