i18n(ja): fix scrambled sentence and mistranslated Key Visualizer link - #23627
Conversation
Found while reviewing PR #23626 (dropped は particle sweep): the paragraph's two EN sentences had their 4 links shuffled together — 2 of the 4 dimension links (Top SQL, Key Visualizer) had been stuffed into the second (link-free in EN) sentence about historical backtracking, making it ungrammatical. Reconstructed to match EN's actual two-sentence structure and fixed the Key Visualizer link text (was mistranslated as 交通ビジュアライザー, matching an EN-side "traffic visualizer" inconsistency being fixed separately upstream).
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughパフォーマンスチューニング概要で、パフォーマンスデータの参照先とPrometheus履歴メトリクスとの比較方法を明示した。 Changesパフォーマンスデータ参照先
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized Japanese documentation correction with no actionable merge-blocking risk remaining beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 114bf683-db8d-4d18-b5d6-bb0dbed0115a
📒 Files selected for processing (1)
performance-tuning-overview.md
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
- hybrid-deployment-topology.md: CodeRabbit correctly flagged that the added は alone didn't fix the remaining broken grammar around deploy_dir/なります; applied a fuller rewrite, verified against EN. - ticdc/ticdc-compatibility.md: fixed the が-drop CodeRabbit found (`data-dir`が正しく構成されている), plus a second を-drop noticed in the same table cell while there (`data-dir`を`cdc server`...). - performance-tuning-overview.md: reverted this PR's は-only patch -- the whole scrambled sentence containing it is already fixed more completely in #23627, so this PR no longer needs to touch the file.
Prometheus stores data as time series; "タイミングメトリクス" (a literal rendering of "timing metrics") could be misread as latency/duration metrics specifically, rather than the general historical metrics data being described.
[LGTM Timeline notifier]Timeline:
|
What is changed, added or deleted? (Required)
Found while reviewing PR #23626:
performance-tuning-overview.md's paragraph describing performance-measurement dimensions had its links scrambled across two EN sentences. EN structure:The JA translation only kept 2 of the 4 dimension links in the first sentence, and stuffed the other 2 (Top SQL, and a mistranslated "Key Visualizer" link rendered as 交通ビジュアライザー) into the second (link-free) sentence, making it ungrammatical.
Reconstructed to match EN's actual two-sentence structure with all 4 links in the first sentence, and fixed the Key Visualizer link text — it was rendered as 交通ビジュアライザー, a literal translation of "traffic visualizer", the generic phrase this one EN sentence used instead of the established "Key Visualizer" proper noun that's kept in English everywhere else in the corpus (a separate EN-side fix for that inconsistency is being filed against master).
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit