i18n(ja): fix dropped topic-marker particle before predicates - #23626
i18n(ja): fix dropped topic-marker particle before predicates#23626yahonda wants to merge 4 commits into
Conversation
ti-chi-bot
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe PR corrects Japanese grammar and phrasing in ten documentation pages. It also clarifies direct-connection requirements for session termination commands in the cluster FAQ. No functional or public entity changes are included. ChangesDocumentation updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR makes localized Japanese documentation wording corrections without introducing actionable merge-blocking risk; it is merge-ready after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Full details: Description checkExplanation The description explains the changes, review scope, false-positive handling, affected documentation version, related PRs, AI involvement, and change categories. The version checkbox differs from the template options, but the intended TiDB 8.5 Japanese documentation scope is clearly stated. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ti-chi-bot
Bot
added
area/develop
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
size/L
1a2da03 to
b2fae22
Compare
ti-chi-bot
Bot
added
size/M
Started at 55 sites/51 files. Two systemic false-positive classes were found and fully reverted through iterative user review: 1. になります/となります predicates (18 sites): the captured code span/bracket is the COMPLEMENT of the "becomes X" predicate, not its subject -- e.g. "この機能が一般提供（GA）となります" was mis-edited to "一般提供（GA）はとなります", which is ungrammatical since GA is what the feature becomes, not a new topic. 2. と呼ばれる/と呼ばれます, を表す/を表します/を意味します/を指す, に相当します/に相当する predicates (24 sites): same complement-vs- subject issue for "is called X" patterns, plus a related structural flaw -- predicates already starting with a particle (を.../に...) mean the code span is already correctly particle-marked as that verb's argument, so inserting は immediately before an existing を/に is always wrong (produces stacked-particle nonsense like 「Xはを指す」). Also reverted 2 sites (dm/dm-error-handling.md, tidb-cloud/sql- concepts.md) that turned out to sit inside a pre-existing, unrelated MT-scramble defect where a particle insertion alone cannot produce a grammatical sentence -- these had already been independently flagged and skipped for the same reason during the earlier が sweep (#23624). 11 sites across 11 files remain, from predicate categories that held up under review (有効です/可能です/サポートされていません/必要です/ デフォルトで/利用できません/含まれます) -- these are still NOT individually re-verified against the English source, so continue to treat this as a draft.
b2fae22 to
e2078b2
Compare
ti-chi-bot
Bot
added
size/S
Per user review: for "you need to [do A] and [do B]" (two verb-ending action phrases), は必要です (a bare-noun-topic construction) reads awkwardly. Reworded to 必要があります (attaches directly to a verb) and changed the conjunction from と to a comma with the first link's displayed text switched to conjunctive (masu-stem) form, matching how Japanese naturally lists two sequential actions before a shared verb.
yahonda
changed the title
ti-chi-bot
Bot
removed
the
do-not-merge/work-in-progress
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4378c41b-9f97-4364-8119-fbb62307c557
📒 Files selected for processing (11)
best-practices/best-practices-on-public-cloud.mdfaq/manage-cluster-faq.mdhybrid-deployment-topology.mdperformance-tuning-overview.mdreleases/release-6.5.0.mdreleases/release-8.2.0.mdsql-statements/sql-statement-backup.mdsql-statements/sql-statement-set-transaction.mdticdc/ticdc-compatibility.mdtidb-cloud/tidb-cloud-encrypt-cmek-aws.mdtidb-rowid.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
yahonda
changed the title
- hybrid-deployment-topology.md: CodeRabbit correctly flagged that the added は alone didn't fix the remaining broken grammar around deploy_dir/なります; applied a fuller rewrite, verified against EN. - ticdc/ticdc-compatibility.md: fixed the が-drop CodeRabbit found (`data-dir`が正しく構成されている), plus a second を-drop noticed in the same table cell while there (`data-dir`を`cdc server`...). - performance-tuning-overview.md: reverted this PR's は-only patch -- the whole scrambled sentence containing it is already fixed more completely in #23627, so this PR no longer needs to touch the file.
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f98061bd-0f98-4619-af48-5ede7899bab1
📒 Files selected for processing (2)
hybrid-deployment-topology.mdticdc/ticdc-compatibility.md
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.
…c-compatibility.md - Per CodeRabbit: added の to bind "v4.0.14以降" to "v4.0バージョン" (and same for v5.0.3/v5.0), matching EN's "v4.0.14 and later v4.0 versions" -- the bare commas could misread as separate conditions. - Found the same が-drop and を-drop pattern (already fixed on the v4.0.14+ row) also present on the sibling v4.0.12-v5.0.1 row just above it in the same table.
1 participant
What is changed, added or deleted? (Required)
Continuation of the dropped-particle review (を: #23579/#23611, が: #23624) for は (topic particle) — dropped immediately after a code span/bracket, before a definitional or state predicate (becomes/is called/represents/corresponds to/is supported/etc.).
Started at 55 sites/51 files from a code-span/bracket-adjacent regex scan. Through iterative human review, two systemic false-positive classes were found and fully reverted:
Also reverted 2 sites that sit inside a pre-existing, unrelated MT-scramble defect where a particle insertion alone can't produce a grammatical sentence (already independently flagged/skipped for the same reason during the が sweep, #23624), and one site (
performance-tuning-overview.md) superseded by a fuller rewrite in #23627.CodeRabbit caught 3 more sites where a partial fix wasn't enough —
hybrid-deployment-topology.mdandticdc/ticdc-compatibility.mdneeded a fuller rewrite beyond just the added particle, both applied and verified against the English source.Reviewed and confirmed clean by the PR author. 11 sites across 11 files remain, from predicate categories that held up under review (有効です/可能です/サポートされていません/必要です/デフォルトで/利用できません/含まれます — state predicates where the code span genuinely is what's being described).
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
_tidb_rowiddocumentation.