Skip to content

i18n(ja): restore literal dotted config/API identifiers mistranslated into Japanese - #23617

Open
yahonda wants to merge 1 commit into
i18n-ja-release-8.5from
fix-mistranslated-config-identifiers
Open

i18n(ja): restore literal dotted config/API identifiers mistranslated into Japanese#23617
yahonda wants to merge 1 commit into
i18n-ja-release-8.5from
fix-mistranslated-config-identifiers

Conversation

@yahonda

@yahonda yahonda commented Aug 27, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Found while reviewing #23616: a dotted config key or API permission string (e.g. storage.objects.list, server.simplify-metrics, gc.auto-compaction) sometimes had one segment translated word-by-word into Japanese, breaking the literal identifier. Fixed 8 such sites across 6 files, all verified against the English source:

  • tidb-cloud/dedicated-external-storage.md: storage.get (missing "objects" segment) → storage.objects.get; storage.オブジェクトリストstorage.objects.list
  • releases/release-6.2.0.md: [サーバー.simplify-metrics][server.simplify-metrics]; [クォータ.バックグラウンド読み取り帯域幅][quota.background-read-bandwidth]
  • tidb-lightning/tidb-lightning-configuration.md: ### tidb.セキュリティ### tidb.security (a separate inline reference to the same section elsewhere in the file was already correctly literal, so this fixes a self-contradiction); ### tidb.セッション変数### tidb.session-vars
  • tikv-configuration-file.md: ## gc.自動圧縮## gc.auto-compaction
  • tiproxy/tiproxy-configuration.md: ### log.ログファイル### log.log-file
  • releases/release-5.3.0.md: ストレージの.block-cache.capacitystorage.block-cache.capacity (also removes a stray leading dot)

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Corrected Japanese descriptions and configuration references in TiDB 5.3.0 and TiKV 6.2.0 release notes.
    • Added and standardized English names for TiKV configuration parameters, including metrics, CPU time, and bandwidth settings.
    • Corrected GCS read-only permission names in external storage documentation.
    • Standardized configuration section headings across TiDB Lightning, TiKV, and TiProxy documentation.

… into Japanese

Fixes 8 sites across 6 files where a segment of a literal dotted config
key or API permission string (e.g. server.simplify-metrics, gc.auto-compaction,
storage.objects.list) had been translated word-by-word into Japanese,
breaking the identifier.
@ti-chi-bot

ti-chi-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: cd677442-9095-4e95-bdd1-98f64e7b6fc5

📥 Commits

Reviewing files that changed from the base of the PR and between d41688a and afa10ed.

📒 Files selected for processing (6)
  • releases/release-5.3.0.md
  • releases/release-6.2.0.md
  • tidb-cloud/dedicated-external-storage.md
  • tidb-lightning/tidb-lightning-configuration.md
  • tikv-configuration-file.md
  • tiproxy/tiproxy-configuration.md

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

This documentation update corrects TiKV configuration references, normalizes configuration headings, updates release-note links, and fixes GCS IAM permission names.

Changes

Documentation corrections

Layer / File(s) Summary
Release note configuration references
releases/release-5.3.0.md, releases/release-6.2.0.md
Corrects the storage.block-cache.capacity reference and updates four TiKV parameter links to their English names.
Configuration heading normalization
tidb-lightning/tidb-lightning-configuration.md, tikv-configuration-file.md, tiproxy/tiproxy-configuration.md
Renames configuration headings to English names. Existing anchor IDs remain unchanged where specified.
GCS permission correction
tidb-cloud/dedicated-external-storage.md
Replaces incorrect GCS permissions with storage.objects.get and storage.objects.list.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to afa10

This change restores literal configuration and API identifiers in Japanese documentation without changing product behavior; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: restoring dotted configuration and API identifiers that were mistranslated into Japanese.
Description check ✅ Passed The description covers the required change summary, affected documentation version, reference context, AI involvement, and change-category checklist. The omitted first-time contributor checklist is op…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (6 skipped: 6 unsupported.)

Full details: Description check

Explanation

The description covers the required change summary, affected documentation version, reference context, AI involvement, and change-category checklist. The omitted first-time contributor checklist is optional.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-mistranslated-config-identifiers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant