Skip to content

Rename server 'Change Password' to 'Change Server Password' (#9230) #10035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpage wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename server 'Change Password' to 'Change Server Password' (#9230) #10035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/en_US/release_notes_9_16.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ Housekeeping

Bug fixes
*********

| `Issue #9230 <https://github.com/pgadmin-org/pgadmin4/issues/9230>`_ - Renamed the server "Change Password" menu option and dialog to "Change Server Password" (including the connected username) to make clear it changes the PostgreSQL server password, not the pgAdmin login password.
8 changes: 6 additions & 2 deletions web/pgadmin/browser/server_groups/servers/static/js/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ define('pgadmin.node.server', [
},{
name: 'change_password', node: 'server', module: this,
applies: ['object'], callback: 'change_password',
label: gettext('Change Password...'), priority: 10,
label: gettext('Change Server Password...'), priority: 10,
enable : 'is_connected',data: {
data_disabled: gettext('Please connect server to enable change password.'),
},
Comment on lines +129 to 132
Expand Down Expand Up @@ -364,7 +364,11 @@ define('pgadmin.node.server', [
if (res.success && res.data.is_pgpass) {
is_pgpass_file_used = true;
}
showChangeServerPassword(gettext('Change Password'), d, obj, i, is_pgpass_file_used);
showChangeServerPassword(
d.user?.name
? gettext('Change Server Password (%s)', d.user.name)
: gettext('Change Server Password'),
d, obj, i, is_pgpass_file_used);
}).catch(function(error) {
pgAdmin.Browser.notifier.pgRespErrorNotify(error);
});
Expand Down
Loading