Rename server 'Change Password' to 'Change Server Password' (#9230)

[dpage]

Summary

Fixes #9230.

The Change Password... menu option on a server node (and its dialog) is ambiguous — it changes the PostgreSQL server password, but reads as if it might change the pgAdmin login password. As discussed on the issue, this renames the menu option and dialog to Change Server Password and includes the connected username in the dialog title to make the target unmistakable.

Changes

• server.js: menu label Change Password... → Change Server Password...; dialog title → Change Server Password (<username>).
• Added release note (9.16).

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Updated the server password change menu option and dialog label to be more descriptive. The dialog now displays "Change Server Password" along with the associated user name when available.

• Documentation

  • Added release notes for pgAdmin 4 v9.16 documenting supported PostgreSQL versions (13–18) and bundled PostgreSQL utility versions including psql, pg_dump, and pg_restore (version 18.4).

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b272bde4-a5c6-4c6f-8da6-de58159c748c

📥 Commits

Reviewing files that changed from the base of the PR and between 1ee57c2 and 245aeb4.

📒 Files selected for processing (2)

• docs/en_US/release_notes_9_16.rst
• web/pgadmin/browser/server_groups/servers/static/js/server.js

✅ Files skipped from review due to trivial changes (1)

• docs/en_US/release_notes_9_16.rst

🚧 Files skipped from review as they are similar to previous changes (1)

• web/pgadmin/browser/server_groups/servers/static/js/server.js

---

Walkthrough

The PR updates pgAdmin 4 version 9.16 release notes to document the rename of the server password dialog from "Change Password..." to "Change Server Password..." for Issue #9230, and implements corresponding UI changes that update the menu label and conditionally display the user name in the dialog title.

Changes

Server password dialog clarification

Layer / File(s)	Summary
Release notes for version 9.16 bug fix documentation docs/en_US/release_notes_9_16.rst	Added release notes entry for Issue #9230 documenting the rename of the "Change Password" menu option and dialog to "Change Server Password" to clarify it targets the PostgreSQL server password.
Server password dialog label and title updates web/pgadmin/browser/server_groups/servers/static/js/server.js	Updated the server context menu to rename the "change_password" action label from "Change Password..." to "Change Server Password...", and modified the dialog title to conditionally include the user name when available.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	❓ Inconclusive	The PR renames the menu label and dialog title to clarify terminology, but the linked issue requests either disabling the dialog or restricting it for non-owner users—neither of which appears fully implemented in the code changes.	Verify whether the label renaming alone addresses the underlying security concern, or if additional restrictions (disabling dialog or owner-only access) need to be implemented as per issue #9230 requirements.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the main change: renaming the server 'Change Password' menu option/dialog to 'Change Server Password' and references the related issue (#9230).
Out of Scope Changes check	✅ Passed	All changes (menu label update, dialog title modification, and release note) are directly related to renaming 'Change Password' to 'Change Server Password' and addressing the confusion described in issue #9230.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Clarifies pgAdmin’s server-node “Change Password…” action by renaming it to “Change Server Password…” and updating the dialog title to include the connected username, reducing confusion with pgAdmin account password changes.

Changes:

• Renamed the server context menu label to “Change Server Password...”.
• Updated the change-password dialog title to “Change Server Password ()” when the connected username is available.
• Added a v9.16 release note entry for the change.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
web/pgadmin/browser/server_groups/servers/static/js/server.js	Renames the menu label and updates the dialog title to include the connected username.
docs/en_US/release_notes_9_16.rst	Documents the UI wording change in the v9.16 bug fixes section.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[asheshv]

Rename is incomplete — two user-visible places still say "Change Password":

1. web/pgadmin/static/js/Dialogs/index.jsx:208 — the pgpass-warning alert that fires right after a successful password change still has title: gettext('Change Password'). The user sees the old label immediately following the action this PR is renaming.
2. web/pgadmin/browser/server_groups/servers/static/js/server.js:131 — data_disabled reads gettext('Please connect server to enable change password.'). The disabled-state tooltip on the renamed menu still says "change password".

Note: utils.js:124 and PgAdminPermissions.py:132 reference the pgAdmin login password (user menu / admin perms), so those should stay as "Change Password" — confirming they're correctly out of scope.

Catalogs (messages.pot + per-locale .po) will need regenerating before release — matches the pattern of commit 2b20beb03. Worth either folding into this PR or noting in the release notes.