Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tabs-passive-scroll.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@patternfly/elements": patch
---

`<pf-tabs>`: scroll event listeners are now passive for better performance.
8 changes: 7 additions & 1 deletion elements/pf-tabs/pf-tabs.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { html, LitElement, type TemplateResult } from 'lit';
import { customElement } from 'lit/decorators/custom-element.js';
import { eventOptions } from 'lit/decorators/event-options.js';
import { property } from 'lit/decorators/property.js';
import { query } from 'lit/decorators/query.js';
import { provide } from '@lit/context';
Expand Down Expand Up @@ -180,7 +181,7 @@ export class PfTabs extends LitElement {
<!-- tablist -->
<div id="tabs" part="tabs" role="tablist">
<!-- Must contain one or more \`<pf-tab>\` -->
<slot name="tab" @slotchange="${this.#onSlotChange}" @scroll="${this.#overflow.onScroll}"></slot>
<slot name="tab" @slotchange="${this.#onSlotChange}" @scroll="${this.onScroll}"></slot>
</div>
${!this.#overflow.showScrollButtons ? '' : html`
<button id="nextTab" tabindex="-1"
Expand All @@ -201,6 +202,11 @@ export class PfTabs extends LitElement {
`;
}

@eventOptions({ passive: true })
private onScroll() {
this.#overflow.onScroll();
}

#scrollLeft() {
this.#overflow.scrollLeft();
}
Expand Down
Loading