Skip to content

perf(tabs): add passive scroll event listeners#3097

Merged
bennypowers merged 4 commits intomainfrom
feat/tabs-passive-scroll
Apr 15, 2026
Merged

perf(tabs): add passive scroll event listeners#3097
bennypowers merged 4 commits intomainfrom
feat/tabs-passive-scroll

Conversation

@bennypowers
Copy link
Copy Markdown
Member

Summary

Use Lit's @eventOptions({ passive: true }) decorator for the scroll
listener in pf-tabs, avoiding blocking the main thread during scroll.

Closes #2600

Test plan

  • Verify tabs still scroll correctly
  • Verify overflow scroll buttons still work

Closes #2600

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 15, 2026

🦋 Changeset detected

Latest commit: 215f361

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2026

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit a357eef
😎 Deploy Preview https://deploy-preview-3097--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "perf(tabs): add passive scroll event listeners"
}

@github-actions github-actions bot added the AT passed Automated testing has passed label Apr 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for 13efed4: Report

@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for 044f94d: Report

@bennypowers bennypowers enabled auto-merge (squash) April 15, 2026 13:13
@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for d525908: Report

@zeroedin zeroedin self-requested a review April 15, 2026 14:44
@bennypowers bennypowers merged commit 6614695 into main Apr 15, 2026
14 checks passed
@bennypowers bennypowers deleted the feat/tabs-passive-scroll branch April 15, 2026 14:51
@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for a357eef: Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] add passive scroll event listeners on tabs

2 participants