docs: require explicit docker image versions - #1576
Merged
Merged
Conversation
Every documented image reference now carries an explicit version tag and the `latest` tag is no longer offered as an option. `owncloud/server:latest` does not necessarily point to the release line documented on this branch, so a container restart can silently pull a different version. The docker page uses a literal `docker-image-version` page attribute rather than one of the global `-version` attributes: those track the latest release of the product, which is not this branch, so interpolating them here would document an image that does not belong to this release line. Also pin the selenium and inbucket images in the UI testing guide, matching the chrome pins the page already carries for owncloud/core#35444. Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
phil-davis
previously approved these changes
Jul 30, 2026
The page deliberately links into the *latest* server version rather than this branch, but it used this branch's page paths. The 11.0 release is docker-only and reorganized accordingly: `installation/index.adoc` (manual installation) is gone, the docker page moved from `installation/docker/index.adoc` to `installation/installing_with_docker.adoc`, and `maintenance/manual_upgrade.adoc` moved under `maintenance/upgrading/`. Three of the five links therefore break as soon as `latest-server-version` advances to 11.0, which fails the aggregated site build. Point them at the paths that exist there and drop the manual installation entry, which has no 11.0 equivalent. Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
The explicit-version requirement is about `owncloud/server` only: its `latest` tag does not track the release line documented here and there are no rolling major or minor tags, so following it installs a version the docs do not describe. That reasoning does not carry over to the selenium and inbucket images used by the UI test setup. Pinning them fixes no documented-version mismatch and only adds pins that nothing in this repo keeps current, so restore them to their previous untagged form. The two `standalone-chrome*` pins stay, they predate this and exist because of owncloud/core#35444. Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
jvillafanez
approved these changes
Jul 31, 2026
kw-tmueller
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every documented
owncloud/serverreference on this branch now carries anexplicit version tag, and
latestis no longer presented as a valid option.owncloud/server:latestdoes not track the release line documented here — itfollows whatever the newest published image happens to be — so a reader copying
the examples, or a container restart, can end up on a different version than the
documentation describes. There are also no rolling major or minor tags
(
owncloud/server:10.16and:10both 404 on Docker Hub), so a full version isthe only correct thing to name.
This applies to
owncloud/serveronly. An earlier revision of this PR alsopinned the selenium and inbucket images in the UI testing guide; those pins are
reverted, since they fix no documented-version mismatch and nothing in this repo
keeps them current.
Changes
modules/admin_manual/pages/installation/docker/index.adocdocker-image-versionpage attribute set to the literal10.16.4.This intentionally does not reuse
{latest-server-version}or{latest-server-download-version}: those are global site attributes that trackthe latest release of the product, and the value that wins is the aggregator's
(
owncloud/docsglobal-attributes.yml), not this branch'santora.yml. Thepage currently renders
OWNCLOUD_VERSION=10.16for that reason, and once theglobal attribute moves to the 11 line it would render an image tag that has
nothing to do with this branch.
docker run(owncloud/server:10.16.4); it wasuntagged, which resolves to
latest.OWNCLOUD_VERSIONin the.envexample and in the required-settings table nownames the explicit version, and the table no longer offers
latest.OWNCLOUD_VERSIONmust be pinned.modules/admin_manual/pages/useful_pages.adoctargets but addressed with this branch's page paths. The 11.0 release is
docker-only and reorganized accordingly, so three of the five links break as
soon as
latest-server-versionadvances.Testing
npm run antora-local(Node 22, as pinned by this branch'sci.yml) builds withonly the two pre-existing
ocis:admin:cross-component xref errors, which areunrelated and cannot resolve in a single-repo build. The rendered page shows
OWNCLOUD_VERSION=10.16.4,owncloud/server:10.16.4, and no occurrence oflatestin the settings table. The10.16.4tag was verified present on DockerHub.
The same change is being made on master (#1575, where the
page is
installing_with_docker.adoc) and on 10.15.