docs: require explicit docker image versions - #1577
Conversation
Every documented image reference now carries an explicit version tag and the `latest` tag is no longer offered as an option. `owncloud/server:latest` does not necessarily point to the release line documented on this branch, so a container restart can silently pull a different version. The docker page uses a literal `docker-image-version` page attribute rather than one of the global `-version` attributes: those track the latest release of the product, which is not this branch, so interpolating them here would document an image that does not belong to this release line. Also pin the selenium and inbucket images in the UI testing guide, matching the chrome pins the page already carries for owncloud/core#35444. Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
The page deliberately links into the *latest* server version rather than this branch, but it used this branch's page paths. The 11.0 release is docker-only and reorganized accordingly: `installation/index.adoc` (manual installation) is gone, the docker page moved from `installation/docker/index.adoc` to `installation/installing_with_docker.adoc`, and `maintenance/manual_upgrade.adoc` moved under `maintenance/upgrading/`. Three of the five links therefore break as soon as `latest-server-version` advances to 11.0, which fails the aggregated site build. Point them at the paths that exist there and drop the manual installation entry, which has no 11.0 equivalent. Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
|
Added a second commit that fixes That page deliberately xrefs into the latest server version rather than this branch, but used this branch's page paths. 11.0 is a docker-only release and reorganized accordingly, so three of the five links break once Unlike on 10.16 this cannot fail the site build, since this branch is being dropped from the published site — but it is the same belt-and-braces reasoning as the
|
Every documented docker image reference on this branch now carries an explicit
version tag, and
latestis no longer presented as a valid option. Same changeas #1576 (10.16) and #1575 (master).
owncloud/server:latestdoes not track the release line documented here — itfollows whatever the newest published image happens to be — so a reader copying
the examples, or a container restart, can end up on a different version than the
documentation describes. There are also no rolling major or minor tags
(
owncloud/server:10.15and:10both 404 on Docker Hub), so a full version isthe only correct thing to name.
Changes
modules/admin_manual/pages/installation/docker/index.adocdocker-image-versionpage attribute set to the literal10.15.3, thetop of this release line. This intentionally does not reuse
{latest-server-version}: that is a global site attribute tracking the latestrelease of the product, and the value that wins is the aggregator's
(
owncloud/docsglobal-attributes.yml), not this branch'santora.yml— whichis why the published page currently renders
OWNCLOUD_VERSION=10.16here.docker run(owncloud/server:10.15.3); it wasuntagged, which resolves to
latest.OWNCLOUD_VERSIONin the.envexample now names the explicit version, and therequired-settings table no longer gives
latestas its example value.OWNCLOUD_VERSIONmust be pinned.modules/developer_manual/pages/testing/ui-testing.adocselenium/standalone-firefox*pulls, the untaggedselenium/standalone-chrome-debugrun, and bothinbucket/inbucketreferences. The selenium pins use
3.141.59-oxygen, matching the chrome pinsthe page already carries because of the issue it links (webUI tests do not run with latest docker-selenium 3.141.59-palladium core#35444);
inbucket uses
3.1.1, its newest release tag. All five tags verified presenton Docker Hub.
Testing
npm run antora-local(Node 22, as pinned by this branch'sci.yml) builds withno errors and no warnings. The rendered page shows
OWNCLOUD_VERSION=10.15.3,owncloud/server:10.15.3, and no occurrence oflatestin the settings table;all five image pins render on the UI testing page.
Note on timing
10.15 is about to be dropped from the published site and archived as
x_archived_10.15, so this content will not be published for long. It is worthmerging anyway: it keeps the branch correct for the window before the
owncloud/docschange lands, and should the branch ever be un-archived it is notleft documenting an image tag that points somewhere else. This PR needs to merge
before the branch is renamed.