Skip to content

Register platform-gcp cluster profile (2/2)#82162

Open
jimdaga wants to merge 1 commit into
openshift:mainfrom
jimdaga:feature/GCP-554-cluster-profile
Open

Register platform-gcp cluster profile (2/2)#82162
jimdaga wants to merge 1 commit into
openshift:mainfrom
jimdaga:feature/GCP-554-cluster-profile

Conversation

@jimdaga

@jimdaga jimdaga commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Step 2 of 2 for adding the platform-gcp cluster profile.

Registers the profile in cluster-profiles-config.yaml. Must merge after #82161 (Boskos + secret bootstrap) so that cluster-secrets-platform-gcp exists on build clusters.

Profile

Field Value
name platform-gcp
cluster_type platform-gcp
lease_type platform-gcp-quota-slice
secret cluster-secrets-platform-gcp
owners openshift-online/gcp-hcp-infra

Depends on: #82161
Jira: GCP-554
Ref: https://docs.ci.openshift.org/how-tos/adding-a-cluster-profile/

Test plan

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Registers the platform-gcp cluster profile for OpenShift CI infrastructure, including its quota-slice lease, cluster secret, and openshift-online/gcp-hcp-infra ownership.
  • Enables CI workflows to request and provision platform-gcp clusters once the required Boskos quota and secret bootstrap is available.

Step 2 of 2: register the platform-gcp cluster profile restricted
to openshift-online/gcp-hcp-infra. Depends on openshift#82161 for Boskos
quota and secret bootstrap.

Part of GCP-554.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2026
@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The cluster profiles configuration adds a platform-gcp entry with its lease type, secret, and ownership assigned to openshift-online and gcp-hcp-infra.

Changes

Platform GCP profile

Layer / File(s) Summary
Define platform-GCP cluster profile
ci-operator/step-registry/cluster-profiles/cluster-profiles-config.yaml
Adds the platform-gcp profile with lease, secret, organization, and repository ownership settings.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: danilo-gemoli, amisstea, josecastillolema

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a YAML cluster-profile config file changed; no Ginkgo test titles were added or modified.
Test Structure And Quality ✅ Passed PR only adds a YAML cluster-profile entry; no Ginkgo test code was added or modified, so the test-quality criteria are not applicable.
Microshift Test Compatibility ✅ Passed PR only changes a cluster-profiles YAML; no new Ginkgo e2e tests were added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only adds a cluster-profile YAML entry; no Ginkgo e2e tests were added or modified, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only a cluster profile config YAML was added; no deployment manifests, controllers, replicas, affinity, or node selectors were changed.
Ote Binary Stdout Contract ✅ Passed Only a YAML cluster-profile entry was added; no process-level code or stdout logging was introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo tests or networking code were added; the PR only updates cluster-profiles-config.yaml, so IPv4/disconnected checks are not applicable.
No-Weak-Crypto ✅ Passed The only added block is YAML metadata for a cluster profile; it contains no crypto primitives or secret/token comparisons.
Container-Privileges ✅ Passed The only changed file is a cluster-profile registry YAML entry; it adds no pod/container security fields like privileged, hostPID, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed Only change is a YAML cluster-profile entry; no logging statements or sensitive-data exposure patterns were added.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: registering the platform-gcp cluster profile, and the part 2 tag is still relevant.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 20, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jimdaga: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jimdaga
Once this PR has been reviewed and has the lgtm label, please assign droslean for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jimdaga
jimdaga marked this pull request as ready for review July 21, 2026 18:44
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2026
@jimdaga

jimdaga commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/hold

Holding for #82161 (must merge first) but also looking to get the review process started.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2026
@openshift-ci
openshift-ci Bot requested review from smg247 and sosiouxme July 21, 2026 18:47
@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@jimdaga: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant