Add platform-gcp Boskos quota and secret bootstrap (1/2)#82161
Conversation
Step 1 of 2 for the platform-gcp cluster profile (per docs.ci.openshift.org/how-tos/adding-a-cluster-profile/). - Add platform-gcp-quota-slice (3 slots) to Boskos generator and regenerate _boskos.yaml - Add ci-secret-bootstrap entry for cluster-secrets-platform-gcp (pull-secret seeding) Vault self-service secret already created at selfservice/gcp-hcp-platform-ci/credentials with WIF credential config (syncs to cluster-secrets-platform-gcp in ci namespace). Profile registration follows in a separate PR after secret sync. Part of GCP-554. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
/test all |
|
@coderabbitai review |
✅ Action performedReview finished.
|
WalkthroughAdds platform GCP CI registry credentials and configures three free ChangesPlatform GCP infrastructure configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core-services/ci-secret-bootstrap/_config.yaml`:
- Around line 5425-5457: Update the pull-secret dockerconfigJSON mapping in the
ci-secret-bootstrap configuration to include the required secret type
kubernetes.io/dockerconfigjson. Preserve all existing registry entries and
cluster target settings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: aa296309-486a-44d9-b7bd-f9cf6ee04504
📒 Files selected for processing (3)
core-services/ci-secret-bootstrap/_config.yamlcore-services/prow/02_config/_boskos.yamlcore-services/prow/02_config/generate-boskos.py
|
@jimdaga: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@jimdaga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danilo-gemoli, jimdaga The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jimdaga: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Step 2 of 2: register the platform-gcp cluster profile restricted to openshift-online/gcp-hcp-infra. Depends on #82161 for Boskos quota and secret bootstrap. Part of GCP-554. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds the step registry and ci-operator config for platform e2e testing: - gcp-hcp-terraform-plan step: authenticates via WIF, runs terraform plan - gcp-hcp-e2e workflow: wif-auth (reused from hypershift) → terraform-plan - e2e-platform test entry in ci-operator config with platform-gcp profile Depends on openshift#82161 (Boskos + secret bootstrap) and openshift#82162 (profile registration). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds the step registry and ci-operator config for platform e2e testing: - gcp-hcp-terraform-plan step: authenticates via WIF, runs terraform plan - gcp-hcp-e2e workflow: wif-auth (reused from hypershift) → terraform-plan - e2e-platform test entry in ci-operator config with platform-gcp profile Depends on openshift#82161 (Boskos + secret bootstrap) and openshift#82162 (profile registration). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Step 1 of 2 for the platform-gcp cluster profile (per docs.ci.openshift.org/how-tos/adding-a-cluster-profile/). - Add platform-gcp-quota-slice (3 slots) to Boskos generator and regenerate _boskos.yaml - Add ci-secret-bootstrap entry for cluster-secrets-platform-gcp (pull-secret seeding) Vault self-service secret already created at selfservice/gcp-hcp-platform-ci/credentials with WIF credential config (syncs to cluster-secrets-platform-gcp in ci namespace). Profile registration follows in a separate PR after secret sync. Part of GCP-554. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Step 2 of 2: register the platform-gcp cluster profile restricted to openshift-online/gcp-hcp-infra. Depends on openshift#82161 for Boskos quota and secret bootstrap. Part of GCP-554. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
Step 1 of 2 for adding the
platform-gcpcluster profile, per the cluster profile docs.This PR adds Boskos quota slots and the secret bootstrap entry. The profile registration follows in a separate PR after secrets have synced to build clusters.
Changes
generate-boskos.py+ regenerated_boskos.yaml):platform-gcp-quota-slicewith 3 concurrent slots_config.yaml): seedcluster-secrets-platform-gcpwith pull-secret dockerconfigJSONVault secret
Self-service secret already created at
selfservice/gcp-hcp-platform-ci/credentialswith:secretsync/target-name:cluster-secrets-platform-gcpwif-config.json,ci-folder-id,billing-account-idNext step
After this merges and secrets sync (~30 min), a follow-up PR will register the
platform-gcpprofile incluster-profiles-config.yaml.#82162
Jira: GCP-554
Test plan
ci/prow/boskos-config-generationpasses🤖 Generated with Claude Code
Summary by CodeRabbit
platform-gcpcluster profile infrastructure for OpenShift CI.platform-gcp-quota-sliceBoskos quota and regenerates its configuration.cluster-secrets-platform-gcpwith pull-secret credentials for non-application CI clusters, using the existing Vault WIF configuration and GCP identifiers.