CNF-25922: Promote cert-manager TechPreview e2e to always-run by sebrandon1 · Pull Request #82098 · openshift/release

sebrandon1 · 2026-07-17T18:25:10Z

Summary

Promote e2e-operator-tech-preview from optional to always-run for cert-manager-operator PRs on master

Details

The master branch actively builds 4 images including cert-manager-istio-csr and cert-manager-trust-manager, both TechPreview features. However, the e2e-operator-tech-preview test that validates these features was optional: true and required manual /test triggering. This meant PRs breaking TechPreview functionality could merge without CI signal.

This change removes optional: true so the test runs automatically on code-changing PRs. The existing skip_if_only_changed pattern ensures doc-only PRs still skip it.

Test plan

make update generates expected Prow job changes
make checkconfig passes
Generated presubmit YAML shows e2e-operator-tech-preview without optional: true

Summary by CodeRabbit

Makes the e2e-operator-tech-preview job always run for cert-manager-operator pull requests targeting master.
Preserves the existing exclusion for documentation-only changes via skip_if_only_changed.

The e2e-operator-tech-preview test validates TechPreview features (istio-csr, trust-manager) but was optional and never auto-ran on PRs. Since the master branch actively builds all four images including istio-csr and trust-manager, this test should run automatically to catch regressions. The existing skip_if_only_changed pattern ensures doc-only PRs still skip it.

openshift-ci-robot · 2026-07-17T18:25:13Z

@sebrandon1: This pull request references CNF-25922 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Promote e2e-operator-tech-preview from optional to always-run for cert-manager-operator PRs on master

Details

The master branch actively builds 4 images including cert-manager-istio-csr and cert-manager-trust-manager, both TechPreview features. However, the e2e-operator-tech-preview test that validates these features was optional: true and required manual /test triggering. This meant PRs breaking TechPreview functionality could merge without CI signal.

This change removes optional: true so the test runs automatically on code-changing PRs. The existing skip_if_only_changed pattern ensures doc-only PRs still skip it.

Test plan

make update generates expected Prow job changes

make checkconfig passes

Generated presubmit YAML shows e2e-operator-tech-preview without optional: true

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-07-17T18:25:36Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign bharath-b-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-07-17T18:25:44Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 556a749b-44ef-4434-a845-7734ae2521a8

📥 Commits

Reviewing files that changed from the base of the PR and between fba1190 and 39c87d6.

⛔ Files ignored due to path filters (1)

ci-operator/jobs/openshift/cert-manager-operator/openshift-cert-manager-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master.yaml

💤 Files with no reviewable changes (1)

ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master.yaml

Walkthrough

The master CI configuration removes optional: true from the e2e-operator-tech-preview job, making the job required while preserving its other settings.

Changes

Cert-manager operator CI

Layer / File(s)	Summary
Make tech-preview e2e job required `ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master.yaml`	Removes the `optional: true` attribute from the `e2e-operator-tech-preview` job.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

openshift/release#81902: Changes the optional setting for another cert-manager-operator e2e job in the same CI configuration file.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes promoting the cert-manager TechPreview e2e job from optional to always-run.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only CI YAML changed; the diff removes optional: true from a presubmit and contains no Ginkgo titles or test-name edits.
Test Structure And Quality	✅ Passed	Only CI YAML was changed; no Ginkgo test code or assertions were modified, so the test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	No Ginkgo test code was added or changed; this PR only removes optional from an existing CI job, so MicroShift compatibility isn’t newly impacted.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only CI job YAML changed; no new/modified Ginkgo e2e tests were added, so SNO assumptions are not implicated.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a CI presubmit config changed; the patch deletes optional:true from e2e-operator-tech-preview and adds no workload scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	Diff is YAML-only; it just removes optional flags in generated CI job configs, with no process-level code or stdout writes touched.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only changes Prow metadata to always-run an existing TechPreview lane; no new Ginkgo test bodies or network code were added.
No-Weak-Crypto	✅ Passed	Diff only removes optional: true in CI YAML; no weak-crypto, custom crypto, or secret-comparison code was added.
Container-Privileges	✅ Passed	The only touched ci-operator YAML removes optional: true; it contains no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation fields.
No-Sensitive-Data-In-Logs	✅ Passed	Diff only removes optional: true from e2e-operator-tech-preview; no log statements or sensitive-data fields were added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

openshift-merge-bot · 2026-07-17T18:27:59Z

[REHEARSALNOTIFIER]
@sebrandon1: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-cert-manager-operator-master-e2e-operator-tech-preview	openshift/cert-manager-operator	presubmit	Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-ci · 2026-07-17T18:34:31Z

@sebrandon1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2026

openshift-ci Bot requested review from TrilokGeer and bharath-b-rh July 17, 2026 18:25

coderabbitai Bot mentioned this pull request Jul 17, 2026

CNF-25927: Promote cert-manager multi-cloud e2e tests to always-run #82099

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CNF-25922: Promote cert-manager TechPreview e2e to always-run#82098

CNF-25922: Promote cert-manager TechPreview e2e to always-run#82098
sebrandon1 wants to merge 1 commit into
openshift:mainfrom
sebrandon1:cert-manager-techpreview-ci

sebrandon1 commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

openshift-ci-robot commented Jul 17, 2026 •

edited by atlassian Bot

Loading

Summary

Details

Test plan

Uh oh!

openshift-ci Bot commented Jul 17, 2026

Uh oh!

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading

Uh oh!

openshift-merge-bot Bot commented Jul 17, 2026

Uh oh!

openshift-ci Bot commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sebrandon1 commented Jul 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Test plan

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Jul 17, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Test plan

Uh oh!

openshift-ci Bot commented Jul 17, 2026

Uh oh!

coderabbitai Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

openshift-merge-bot Bot commented Jul 17, 2026

Uh oh!

openshift-ci Bot commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sebrandon1 commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Jul 17, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading