CNF-25927: Promote cert-manager multi-cloud e2e tests to always-run

[sebrandon1]

Summary

• Promote e2e-operator-aws-sts and e2e-operator-gcp-ovn from optional to always-run for cert-manager-operator PRs on master

Details

All 8 multi-cloud and credential-mode e2e tests were always_run: false, optional: true, meaning they only ran when manually triggered with /test. In practice this left GCP, Azure, and Manual credential modes (STS/Workload Identity) with no automatic PR coverage.

This promotes two tests to always-run:

• e2e-operator-aws-sts — validates Manual credential mode (STS/OIDC), important for security-conscious deployments
• e2e-operator-gcp-ovn — validates a non-AWS cloud provider entirely

Both use skip_if_only_changed to skip doc-only PRs. The remaining 6 optional tests (Azure, proxy, UPI proxy, GCP WI, Azure WI) stay optional.

Test plan

• make update generates expected Prow job changes
• make checkconfig passes
• Generated presubmit YAML shows both tests without optional: true or always_run: false

Summary by CodeRabbit

Updates cert-manager-operator’s OpenShift CI on master so AWS STS and GCP OVN end-to-end tests run automatically for pull requests, while still skipping documentation-only changes. The other multi-cloud and credential-mode tests remain optional.

[openshift-ci-robot]

@sebrandon1: This pull request references CNF-25927 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

• Promote e2e-operator-aws-sts and e2e-operator-gcp-ovn from optional to always-run for cert-manager-operator PRs on master

Details

All 8 multi-cloud and credential-mode e2e tests were always_run: false, optional: true, meaning they only ran when manually triggered with /test. In practice this left GCP, Azure, and Manual credential modes (STS/Workload Identity) with no automatic PR coverage.

This promotes two tests to always-run:

• e2e-operator-aws-sts — validates Manual credential mode (STS/OIDC), important for security-conscious deployments
• e2e-operator-gcp-ovn — validates a non-AWS cloud provider entirely

Both use skip_if_only_changed to skip doc-only PRs. The remaining 6 optional tests (Azure, proxy, UPI proxy, GCP WI, Azure WI) stay optional.

Test plan

• make update generates expected Prow job changes
• make checkconfig passes
• Generated presubmit YAML shows both tests without optional: true or always_run: false

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign bharath-b-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/cert-manager-operator/OWNERS
• ci-operator/jobs/openshift/cert-manager-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 94a23e04-7ee2-483e-b224-b8b7440709d5

📥 Commits

Reviewing files that changed from the base of the PR and between fba1190 and 882013e.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/cert-manager-operator/openshift-cert-manager-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master.yaml

---

Walkthrough

Updated the e2e-operator-aws-sts and e2e-operator-gcp-ovn CI job metadata to remove optional and always-run settings while using path-based skip filters.

Changes

Cert-manager CI job gating

Layer / File(s)	Summary
Update e2e job execution metadata ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master.yaml	Both e2e jobs remove always_run: false and optional: true, while retaining matching skip_if_only_changed path filters.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openshift/release#82085: Adjusts similar CI job execution gating fields for other operator jobs.
• openshift/release#82098: Updates related cert-manager operator e2e job metadata in the same configuration file.

Suggested reviewers: jcantrill

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: promoting cert-manager multi-cloud e2e tests to always-run.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only edits ci-operator job metadata; no It/Describe/Context/When titles or dynamic identifiers were added, and job names are static.
Test Structure And Quality	✅ Passed	PR only changes CI YAML job configs; no Ginkgo test code was modified, so the test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	PR only changes CI job metadata for existing jobs; no Ginkgo tests/specs were added or modified, so MicroShift compatibility isn’t newly impacted.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only changes CI metadata for existing e2e jobs; no new Ginkgo specs or node-topology assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The PR only updates ci-operator/job metadata for presubmits; no deployment manifests, controllers, or scheduling constraints changed.
Ote Binary Stdout Contract	✅ Passed	The commit only changes CI YAML/job config; no process-level binary code or stdout writes were touched.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The PR only updates CI job YAML; no Ginkgo test bodies were added or changed, so there are no new IPv4 or external-connectivity assumptions to flag.
No-Weak-Crypto	✅ Passed	Only CI job metadata changed; searches found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or timing comparisons.
Container-Privileges	✅ Passed	The patch only changes ci-operator job metadata; no privileged, hostPID/Network/IPC, SYS_ADMIN, allowPrivilegeEscalation, or root settings were added.
No-Sensitive-Data-In-Logs	✅ Passed	Changed CI job metadata only; no added logging or secret/token/PII exposure in the modified job stanzas.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@sebrandon1: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-cert-manager-operator-master-e2e-operator-aws-sts	openshift/cert-manager-operator	presubmit	Presubmit changed
pull-ci-openshift-cert-manager-operator-master-e2e-operator-gcp-ovn	openshift/cert-manager-operator	presubmit	Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@sebrandon1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.