Skip to content

Backport dynamic OTE suite discovery to release-4.19#31414

Open
danchild wants to merge 1 commit into
openshift:release-4.19from
shiftstack:ote-extension-derived-suites-4.19
Open

Backport dynamic OTE suite discovery to release-4.19#31414
danchild wants to merge 1 commit into
openshift:release-4.19from
shiftstack:ote-extension-derived-suites-4.19

Conversation

@danchild

@danchild danchild commented Jul 22, 2026

Copy link
Copy Markdown
Member

Backport dynamic OTE suite discovery to 4.19
Ths work is an extension to the admission and extraction of
non-payload test binaries in #31404,

In 4.20, an AllTestSuites fucntion was introduced through
c4895d7 to allow the discovery of extension-declared suites.
The changes here intoduce the ability discover
extension-declared suites without needing the full OTE refactoring
introduced in 4.20.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a0c86295-91d6-420b-8e40-c86b50be442f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2026
@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the vendor-update Touching vendor dir or related files label Jul 22, 2026
@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danchild
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danchild
danchild force-pushed the ote-extension-derived-suites-4.19 branch 3 times, most recently from 1a40737 to 233e720 Compare July 22, 2026 20:03
@danchild
danchild marked this pull request as ready for review July 22, 2026 20:03
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2026
@openshift-ci
openshift-ci Bot requested review from p0lyn0mial and sjenning July 22, 2026 20:05
@ekuris-redhat

Copy link
Copy Markdown

/retest-required

Ths work is an extension to the admission and extraction of
non-payload test binaries in openshift#31404,

In 4.20, a `AllTestSuites` fucntion was introduced through
c4895d7 to allow the discovery of extension-declared suites.
The changes here intoduce the ability discover
extension-declared suites without needing the full OTE refactoring
introduced in 4.20.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Dan Childers <dchilder@redhat.com>
@danchild
danchild force-pushed the ote-extension-derived-suites-4.19 branch from 233e720 to f28f7bb Compare July 23, 2026 13:42
@danchild

Copy link
Copy Markdown
Member Author

/test e2e-gcp-ovn

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@danchild: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danchild

Copy link
Copy Markdown
Member Author

/verified by @danchild

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 24, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@danchild: This PR has been marked as verified by @danchild.

Details

In response to this:

/verified by @danchild

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vendor-update Touching vendor dir or related files verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants