openstack-test: migrate CI config to OTE (openshift-tests-extension), 4.22-4.19#81677
openstack-test: migrate CI config to OTE (openshift-tests-extension), 4.22-4.19#81677danchild wants to merge 1 commit into
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
WalkthroughOpenStack release CI configurations for versions 4.19–4.22 now build and validate the tests extension binary, and update dual-stack workflow references to use the OTE test ref alongside ChangesOpenStack test CI configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/assign @mandre |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.14.yaml`:
- Around line 1-4: The 4.14 ProwJob artifacts are out of sync with the updated
ci-operator config, so the generated jobs under
ci-operator/jobs/openshift/openstack-test still reference the old ref.
Regenerate the affected presubmit/postsubmit job files for
openshift/openstack-test, including any matching release variants, so they pick
up the new openstack-test-openstack-ote reference from the
openshift-openstack-test-release-4.14 configuration. If needed, validate the
regenerated artifacts with a passing pj-rehearse or ci-operator-config run.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: d4c545a8-8a05-4f62-8c40-bc095ee2796c
📒 Files selected for processing (9)
ci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.14.yamlci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.15.yamlci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.16.yamlci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.17.yamlci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.18.yamlci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.19.yamlci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.20.yamlci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.21.yamlci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.22.yaml
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.22-build pull-ci-openshift-openstack-test-release-4.22-images pull-ci-openshift-openstack-test-release-4.22-verify |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.22-test |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.21-build pull-ci-openshift-openstack-test-release-4.21-images pull-ci-openshift-openstack-test-release-4.21-verify |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.20-build pull-ci-openshift-openstack-test-release-4.20-images pull-ci-openshift-openstack-test-release-4.20-verify |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.21-test |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.19-build pull-ci-openshift-openstack-test-release-4.19-images pull-ci-openshift-openstack-test-release-4.19-verify |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.18-build pull-ci-openshift-openstack-test-release-4.18-images pull-ci-openshift-openstack-test-release-4.18-verify |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.17-build pull-ci-openshift-openstack-test-release-4.17-images |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.17-verify pull-ci-openshift-openstack-test-release-4.16-build pull-ci-openshift-openstack-test-release-4.16-images pull-ci-openshift-openstack-test-release-4.16-verify |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.14-verify |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
besides the question up there, I'll suggest to make the one path/release working rather, and then check the reset instead of doing it all at once. |
Summary: - Mirroring combination of PRs: openshift#80335 openshift#80209 openshift#79487 - Releases 4.22 - 4.19 - Original commit message and fix by @mandre Releases: Update the openstack-test main CI configuration to support the OTE migration in: openshift/openstack-test#266 (release-4.22) openshift/openstack-test#267 (release-4.21) openshift/openstack-test#268 (release-4.20) openshift/openstack-test#269 (release-4.19) Changes: - binary_build_commands: build OTE extension binary via 'make tests-ext-build', package as tar.gz, and place at /usr/bin/ for payload discovery by openshift-tests - build test: verify the extension binary with --help instead of the removed openstack-tests binary - test/ccpmso jobs: use new openstack-test-openstack-ote step ref - dualstack jobs: override test phase with openshift-e2e-test + openstack-test-openstack-ote (replacing the old chain that used openstack-test-openstack) Dependencies: - step registry ref openstack-test-openstack-ote created in openshift#79487 The old openstack-test-openstack step ref is preserved for older release branches that still use the standalone openstack-tests binary.
a926159 to
88adb79
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danchild The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
A total of 28 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
danchild
changed the title
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.22-build pull-ci-openshift-openstack-test-release-4.22-verify pull-ci-openshift-openstack-test-release-4.22-images pull-ci-openshift-openstack-test-release-4.22-test |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.21-build pull-ci-openshift-openstack-test-release-4.21-verify pull-ci-openshift-openstack-test-release-4.21-images pull-ci-openshift-openstack-test-release-4.21-test |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.20-build pull-ci-openshift-openstack-test-release-4.20-verify pull-ci-openshift-openstack-test-release-4.20-images pull-ci-openshift-openstack-test-release-4.20-test |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
danchild
changed the title
danchild
changed the title
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.19-build pull-ci-openshift-openstack-test-release-4.19-verify pull-ci-openshift-openstack-test-release-4.19-images |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.19-test |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.19-test |
|
@ekuris-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.20-test |
|
@ekuris-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Tests for 4.20 are false negative - sometimes amphora lb is too slow, and therefore fail. As for 4.19 it's not so good: |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.19-test |
|
@gryf: your |
|
/pj-rehearse pull-ci-openshift-openstack-test-release-4.20-test |
|
@danchild: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@danchild: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Thanks for the direction @gryf. The CRD is there - it was introduced in openshift/origin#31404. We got further along the call chain, but it looks like OTE can't find I created openshift/origin#31414 and should do the trick (I'm waiting on feedback from that team). |
4 participants
Summary:
openstack: restore the openstack-tests building #80335
openstack-test: Build both binaries #80209
openstack-test: migrate CI config to OTE (openshift-tests-extension) #79487
Releases:
Update the openstack-test main CI configuration to support the OTE
migration in:
openshift/openstack-test#266 (release-4.22)
openshift/openstack-test#267 (release-4.21)
openshift/openstack-test#268 (release-4.20)
openshift/openstack-test#269 (release-4.19)
Changes:
tests-ext-build', package as tar.gz, and place at /usr/bin/ for
payload discovery by openshift-tests
removed openstack-tests binary
openstack-test-openstack-ote (replacing the old chain that used
openstack-test-openstack)
Dependencies:
The old openstack-test-openstack step ref is preserved for older release
branches that still use the standalone openstack-tests binary.
Summary by CodeRabbit
Migrates OpenStack CI configurations for OpenShift releases 4.19–4.22 to use the
openshift-tests-extension(OTE) binary. The CI now builds, packages, and validates the extension for payload discovery, updates standard and CCPMSO workflows to useopenstack-test-openstack-ote, and adds the OTE step to dual-stack jobs alongsideopenshift-e2e-test.