[release-4.22] OCPBUGS-105364: Azure: delete bootstrap ignition storage during bootstrap destroy - #10778
Conversation
The installer creates a storage account to host bootstrap.ign during Azure IPI installs but never deletes it during bootstrap destroy. This leaves sensitive bootstrap data (CA certs, auth tokens) in a network-accessible storage account for the lifetime of the cluster. Extend PostDestroy to delete the ignition container and, if no other containers remain (e.g. vhd for OKD/confidential VM image gallery), delete the entire storage account. Azure Stack is excluded (uses a different storage SDK). Cleanup is best-effort: failures log a warning but do not block install completion. Co-authored-by: Cursor <cursoragent@cursor.com>
(cherry picked from commit 19f9d3f)
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@chdeshpa-hue: This pull request references Jira Issue OCPBUGS-105364, which is valid. 7 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pipeline required |
|
Scheduling tests matching the |
|
/label backport-risk-assessed |
|
@chdeshpa-hue: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by @chdeshpa-hue |
|
@chdeshpa-hue: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Summary
release-4.22(clone: OCPBUGS-105364).19f9d3fd80c9from main (update gcloud sdk to 563inimages/installer/Dockerfile.upi.ci) soci/prow/e2e-aws-ovncan pass, per @IlanZuckerman on [release-4.22] OCPBUGS-105364: Azure: delete bootstrap ignition storage during bootstrap destroy #10747.Fixes: https://issues.redhat.com/browse/OCPBUGS-105364
Test plan
19f9d3fdapplied cleanly onto [release-4.22] OCPBUGS-105364: Azure: delete bootstrap ignition storage during bootstrap destroy #10747 HEADci/prow/e2e-aws-ovngreen (the gcloud 563 pin)ci/prow/e2e-azure-ovn/ci/prow/images/ci/prow/okd-scos-imagesre-run on this HEAD/lgtm,/approve,/label backport-risk-assessed,/verified(labels do not carry over from [release-4.22] OCPBUGS-105364: Azure: delete bootstrap ignition storage during bootstrap destroy #10747)Made with Cursor