Skip to content

[release-4.22] OCPBUGS-105364: Azure: delete bootstrap ignition storage during bootstrap destroy - #10778

Open
chdeshpa-hue wants to merge 2 commits into
openshift:release-4.22from
chdeshpa-hue:cherry-pick-10747-gcloud-563
Open

[release-4.22] OCPBUGS-105364: Azure: delete bootstrap ignition storage during bootstrap destroy#10778
chdeshpa-hue wants to merge 2 commits into
openshift:release-4.22from
chdeshpa-hue:cherry-pick-10747-gcloud-563

Conversation

@chdeshpa-hue

Copy link
Copy Markdown
Contributor

Summary

Fixes: https://issues.redhat.com/browse/OCPBUGS-105364

Test plan

Made with Cursor

chdeshpa-hue and others added 2 commits August 7, 2026 01:21
The installer creates a storage account to host bootstrap.ign during
Azure IPI installs but never deletes it during bootstrap destroy.
This leaves sensitive bootstrap data (CA certs, auth tokens) in a
network-accessible storage account for the lifetime of the cluster.

Extend PostDestroy to delete the ignition container and, if no other
containers remain (e.g. vhd for OKD/confidential VM image gallery),
delete the entire storage account. Azure Stack is excluded (uses a
different storage SDK). Cleanup is best-effort: failures log a warning
but do not block install completion.

Co-authored-by: Cursor <cursoragent@cursor.com>
(cherry picked from commit 19f9d3f)
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@chdeshpa-hue: This pull request references Jira Issue OCPBUGS-105364, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-98700 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-98700 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Fixes: https://issues.redhat.com/browse/OCPBUGS-105364

Test plan

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 20, 2026
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1761d5b4-3e05-4173-af70-392166667676

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zaneb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadasu

sadasu commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-upi
/test e2e-azure-default-config
/test e2e-azure-ovn
/test e2e-azure-ovn-shared-vpc
/test e2e-azure-ovn-upi
/test e2e-azurestack
/test e2e-gcp-ovn-upi
/test e2e-vsphere-ovn-upi
/test e2e-vsphere-ovn-upi-zones
/test e2e-aws-ovn

@sadasu

sadasu commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 20, 2026
@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

@chdeshpa-hue: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/azure-private 10d2578 link false /test azure-private
ci/prow/e2e-azurestack 10d2578 link false /test e2e-azurestack
ci/prow/e2e-azure-ovn-upi 10d2578 link false /test e2e-azure-ovn-upi
ci/prow/e2e-azure-ovn 10d2578 link true /test e2e-azure-ovn
ci/prow/e2e-azure-ovn-shared-vpc 10d2578 link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-vsphere-ovn-upi-zones 10d2578 link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-aws-ovn 10d2578 link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-upi 10d2578 link true /test e2e-aws-ovn-upi
ci/prow/e2e-azure-default-config 10d2578 link false /test e2e-azure-default-config
ci/prow/e2e-gcp-ovn-upi 10d2578 link true /test e2e-gcp-ovn-upi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@chdeshpa-hue

Copy link
Copy Markdown
Contributor Author

/verified by @chdeshpa-hue

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 22, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@chdeshpa-hue: This PR has been marked as verified by @chdeshpa-hue.

Details

In response to this:

/verified by @chdeshpa-hue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants