Skip to content

[release-4.22] OCPBUGS-105364: Azure: delete bootstrap ignition storage during bootstrap destroy - #10747

Closed
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-10701-to-release-4.22
Closed

[release-4.22] OCPBUGS-105364: Azure: delete bootstrap ignition storage during bootstrap destroy#10747
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-10701-to-release-4.22

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #10701

/assign chdeshpa-hue

The installer creates a storage account to host bootstrap.ign during
Azure IPI installs but never deletes it during bootstrap destroy.
This leaves sensitive bootstrap data (CA certs, auth tokens) in a
network-accessible storage account for the lifetime of the cluster.

Extend PostDestroy to delete the ignition container and, if no other
containers remain (e.g. vhd for OKD/confidential VM image gallery),
delete the entire storage account. Azure Stack is excluded (uses a
different storage SDK). Cleanup is best-effort: failures log a warning
but do not block install completion.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f41b6dbc-438d-43a3-a2d0-22864f258a8e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jhixson74 and rna-afk August 7, 2026 01:21
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-98700 has been cloned as Jira Issue OCPBUGS-105364. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-105364: Azure: delete bootstrap ignition storage during bootstrap destroy

Details

In response to this:

This is an automated cherry-pick of #10701

/assign chdeshpa-hue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.22] OCPBUGS-98700: Azure: delete bootstrap ignition storage during bootstrap destroy [release-4.22] OCPBUGS-105364: Azure: delete bootstrap ignition storage during bootstrap destroy Aug 7, 2026
@chdeshpa-hue chdeshpa-hue removed their assignment Aug 7, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 7, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-105364, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-98700 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-98700 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #10701

/assign chdeshpa-hue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@chdeshpa-hue

Copy link
Copy Markdown
Contributor

/retest-required

@chdeshpa-hue

Copy link
Copy Markdown
Contributor

/verified by @chdeshpa-hue

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 7, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@chdeshpa-hue: This PR has been marked as verified by @chdeshpa-hue.

Details

In response to this:

/verified by @chdeshpa-hue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhixson74

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-azure-default-config
/test e2e-azure-ovn
/test e2e-azure-ovn-shared-vpc
/test e2e-azurestack
/test e2e-aws-ovn

@chdeshpa-hue

Copy link
Copy Markdown
Contributor

/retest

@chdeshpa-hue

Copy link
Copy Markdown
Contributor

@jhixson74 can you also provide, approved, backport-risk-assessed labels

@sadasu

sadasu commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

/approve

@sadasu

sadasu commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 19, 2026
@sadasu

sadasu commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

/retest-required

@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2026
@IlanZuckerman

Copy link
Copy Markdown
Contributor

To make the ci/prow/e2e-aws-ovn pass you need to update gcloud sdk to 563. Cherry pick commit 19f9d3f from main

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 27857bd and 2 for PR HEAD 716ed25 in total

@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-shared-vpc 716ed25 link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-azure-default-config 716ed25 link false /test e2e-azure-default-config
ci/prow/e2e-azurestack 716ed25 link false /test e2e-azurestack
ci/prow/azure-private 716ed25 link false /test azure-private
ci/prow/azure-ovn-marketplace-images 716ed25 link false /test azure-ovn-marketplace-images
ci/prow/e2e-azure-ovn 716ed25 link true /test e2e-azure-ovn
ci/prow/images 716ed25 link true /test images
ci/prow/okd-scos-images 716ed25 link true /test okd-scos-images
ci/prow/e2e-aws-ovn 716ed25 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@chdeshpa-hue

Copy link
Copy Markdown
Contributor

The cherry-pick-robot branch is not writable, so I could not add the gcloud SDK 563 pin here.

Replacement PR with the original backport plus cherry-pick of 19f9d3f: #10778

Closing this one as superseded.

@chdeshpa-hue

Copy link
Copy Markdown
Contributor

Superseded by #10778 (adds gcloud SDK 563 pin requested by @IlanZuckerman).

@sadasu

sadasu commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

/close

Replaced by #10778.

@openshift-ci openshift-ci Bot closed this Aug 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-105364. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #10701

/assign chdeshpa-hue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

@sadasu: Closed this PR.

Details

In response to this:

/close

Replaced by #10778.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants