NO-JIRA: Revert "OCPBUGS-87109 Scope minted AWS IAM policies to cluster-owned resources"

[amitesh1201]

Summary

This reverts commit 298c3e8 (PR #1047).

Why

PR #1043 (cherry-picked as #1047 to this branch) caused regressions in the
e2e-aws-csi job — all snapshot-related tests have been permafailing since Jun 29.

• OCPBUGS-96892 — aws-csi tests fail to create snapshots
• OCPBUGS-97745 — required origin presubmit aws-csi permafail

Unreverting

A corrected version of the feature is being investigated in PR #1054.

cc @nrb @dlom @neisw

[openshift-ci-robot]

@amitesh1201: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

This reverts commit 298c3e8 (PR #1047).

Why

PR #1043 (cherry-picked as #1047 to this branch) caused regressions in the
e2e-aws-csi job — all snapshot-related tests have been permafailing since Jun 29.

• OCPBUGS-96892 — aws-csi tests fail to create snapshots
• OCPBUGS-97745 — required origin presubmit aws-csi permafail

Unreverting

A corrected version of the feature is being investigated in PR #1054.

cc @nrb @dlom

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0870cbc5-062e-4557-96b0-ea082875779a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.79%. Comparing base (e081490) to head (37728d9).

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.20    #1061      +/-   ##
================================================
- Coverage         47.05%   46.79%   -0.27%     
================================================
  Files                97       97              
  Lines             12053    12005      -48     
================================================
- Hits               5672     5618      -54     
- Misses             5762     5769       +7     
+ Partials            619      618       -1     

Files with missing lines	Coverage Δ
pkg/aws/actuator/actuator.go	65.44% <100.00%> (-1.49%)	⬇️
pkg/aws/utils.go	66.66% <ø> (-3.79%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dlom]

/override ci/prow/security

[openshift-ci]

@dlom: Overrode contexts on behalf of dlom: ci/prow/security

Details

In response to this:

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dlom]

/test e2e-aws-qe

[dlom]

/test e2e-hypershift

[dlom]

/label backport-risk-assessed

[dlom]

/approve

[dlom]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitesh1201, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dlom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dlom]

/verified by previous known good state

[openshift-ci-robot]

@dlom: This PR has been marked as verified by previous known good state.

Details

In response to this:

/verified by previous known good state

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dlom]

/override ci/prow/e2e-hypershift

[openshift-ci]

@dlom: Overrode contexts on behalf of dlom: ci/prow/e2e-hypershift

Details

In response to this:

/override ci/prow/e2e-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@amitesh1201: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	37728d9	link	true	/test security
ci/prow/e2e-hypershift	37728d9	link	true	/test e2e-hypershift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[amitesh1201]

/jira refresh

[openshift-ci-robot]

@amitesh1201: This pull request explicitly references no jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[prabhapa]

/label jira/skip-dependent-bug-check
as this is NO-JIRA ticket

[JoelSpeed]

/label jira/valid-bug

This is a revert of an regression that we need to merge promptly to catch dev cut-off today