OCPBUGS-96892: Revert "OCPBUGS-87829: Scope minted AWS IAM policies to cluster-owned resources"

[redhat-chai-bot]

Summary

This reverts commit 383d3a2 (PR #1043), which introduced scoped IAM policies for cluster-owned resources.

Why

PR #1043 caused multiple regressions in the e2e-aws-csi job — all snapshot-related tests have been permafailing since Jun 29. This has blocked PRs from merging in any repository that uses aws-csi as a required presubmit, including openshift/origin.

• OCPBUGS-96892 — aws-csi tests fail to create snapshots
• OCPBUGS-97745 — required origin presubmit aws-csi permafail

Merge conflict resolution

PR #1053 (OCPBUGS-95187: Reclassify ec2:ModifyNetworkInterfaceAttribute as unscoped) modified the scoped/unscoped action maps introduced by #1043. Since this revert removes those maps entirely, #1053's changes are also effectively reverted and will need to be re-applied when the scoping feature is re-landed.

Unreverting

To unrevert, please land a corrected version of this feature that fixes the snapshot test failures and verify with:

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-csi

A fix is being investigated in PR #1054.

[openshift-ci-robot]

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-96892, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

This reverts commit 383d3a2 (PR #1043), which introduced scoped IAM policies for cluster-owned resources.

Why

PR #1043 caused multiple regressions in the e2e-aws-csi job — all snapshot-related tests have been permafailing since Jun 29. This has blocked PRs from merging in any repository that uses aws-csi as a required presubmit, including openshift/origin.

• OCPBUGS-96892 — aws-csi tests fail to create snapshots
• OCPBUGS-97745 — required origin presubmit aws-csi permafail

Merge conflict resolution

PR #1053 (OCPBUGS-95187: Reclassify ec2:ModifyNetworkInterfaceAttribute as unscoped) modified the scoped/unscoped action maps introduced by #1043. Since this revert removes those maps entirely, #1053's changes are also effectively reverted and will need to be re-applied when the scoping feature is re-landed.

Unreverting

To unrevert, please land a corrected version of this feature that fixes the snapshot test failures and verify with:

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-csi

A fix is being investigated in PR #1054.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Warning

Review limit reached

@redhat-chai-bot, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 134e3b7e-32af-4d03-8e3b-dc4575b54231

📥 Commits

Reviewing files that changed from the base of the PR and between d9f0942 and 4ce2d15.

📒 Files selected for processing (5)

• hack/verify-action-maps.sh
• pkg/aws/actuator/actuator.go
• pkg/aws/actuator/actuator_test.go
• pkg/aws/utils.go
• pkg/aws/utils_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign dlom for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dgoodwin]

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-csi

If this passes I will merge the revert today.

[openshift-ci]

@dgoodwin: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/468eaa30-76e1-11f1-9fce-07bb33211d05-0

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.03%. Comparing base (d9f0942) to head (4ce2d15).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1057      +/-   ##
==========================================
- Coverage   47.28%   47.03%   -0.25%     
==========================================
  Files          97       97              
  Lines       12631    12583      -48     
==========================================
- Hits         5973     5919      -54     
- Misses       6001     6008       +7     
+ Partials      657      656       -1     

Files with missing lines	Coverage Δ
pkg/aws/actuator/actuator.go	67.15% <100.00%> (-1.47%)	⬇️
pkg/aws/utils.go	83.87% <ø> (-2.25%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

@redhat-chai-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	4ce2d15	link	true	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.