Track top-level review actions individually#78
Draft
trask wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds independent lifecycle tracking for actionable top-level review feedback.
Changes:
- Introduces deterministic action-item routing and evidence tracking.
- Updates reviewer indicators, notifications, and state migration.
- Adds documentation and regression tests.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
pull-request-dashboard/README.md |
Documents top-level feedback tracking. |
.github/workflows/pull-request-dashboard-repo.yml |
Updates review guidance. |
.github/scripts/pull-request-dashboard/test_state.py |
Tests notification-state compatibility. |
.github/scripts/pull-request-dashboard/test_mainline_actions.py |
Tests action-ledger behavior. |
.github/scripts/pull-request-dashboard/state.py |
Migrates dashboard state safely. |
.github/scripts/pull-request-dashboard/render.py |
Renders new feedback indicators. |
.github/scripts/pull-request-dashboard/RATIONALE.md |
Explains lifecycle design. |
.github/scripts/pull-request-dashboard/notifications.py |
Includes pending feedback reviewers. |
.github/scripts/pull-request-dashboard/github_cli.py |
Fetches PR edit metadata. |
.github/scripts/pull-request-dashboard/dashboard.py |
Implements item grouping and lifecycle routing. |
.github/scripts/pull-request-dashboard/classification.py |
Adds top-level action classification. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trask
force-pushed
the
mainline-conversation-action-ledger
branch
from
17b635c to
2264157
Compare
trask
force-pushed
the
mainline-conversation-action-ledger
branch
from
2264157 to
dbcda06
Compare
Mechanical, behavior-preserving rename of thread-oriented identifiers and data keys (thread_id, thread_action, thread_kind, thread_facts, and related functions and constants) to discussion in classification.py, dashboard.py, and render.py. No logic changes. This changes the classification cache key; the follow-up commit busts the cache anyway.
trask
force-pushed
the
mainline-conversation-action-ledger
branch
from
dbcda06 to
3459039
Compare
Track each actionable top-level review comment as a stable, independent item instead of collapsing the PR conversation into one synthetic thread. The dashboard classifies the expected evidence, deterministically hands requests between authors and reviewers based on commits, description edits, replies, and requester confirmation, and keeps pending mainline feedback visible until it is confirmed. This also makes Request changes a deterministic author action and updates reviewer guidance, notification behavior, state migration, and regression coverage.
trask
force-pushed
the
mainline-conversation-action-ledger
branch
from
3459039 to
9cf9e81
Compare
Comment on lines
+841
to
+845
| confirmation_at = first_reviewer_confirmation( | ||
| events, | ||
| discussion.get("requester") or "", | ||
| evidence_at or discussion.get("root_timestamp") or "", | ||
| excluded_source_events, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track each actionable top-level review comment as a stable, independent item instead of collapsing the PR conversation into one synthetic thread. The dashboard classifies the expected evidence, deterministically hands requests between authors and reviewers based on commits, description edits, replies, and requester confirmation, and keeps pending mainline feedback visible until it is confirmed. This also makes Request changes a deterministic author action and updates reviewer guidance, notification behavior, state migration, and regression coverage.