Rename thread to discussion in pull request dashboard scripts#84
Closed
trask wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Renames internal pull-request dashboard classification terminology from “thread” to “discussion.”
Changes:
- Renames classification functions, constants, and record keys.
- Updates dashboard routing and diagnostics consumers.
- Updates rendered classification diagnostics.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
classification.py |
Renames discussion classification APIs and schema. |
dashboard.py |
Adopts renamed APIs and keys. |
render.py |
Renders renamed diagnostic fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Mechanical, behavior-preserving rename of thread-oriented Python identifiers (functions and constants) to discussion in classification.py, dashboard.py, and render.py. No logic changes. The classification cache keys thread_action, thread_id, thread_kind, and thread_facts are intentionally left unchanged so this rename does not invalidate the restored classification cache. Those data keys are renamed in the follow-up feature PR, which changes the cache key anyway.
trask
force-pushed
the
rename-thread-to-discussion
branch
from
July 15, 2026 23:43
c82457a to
bff603f
Compare
Comment on lines
+243
to
+244
| "prompt_template": DISCUSSION_PROMPT_TEMPLATE, | ||
| "thread": discussion_prompt_input(thread), |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanical, behavior-preserving rename of thread-oriented Python identifiers (functions and constants) to
discussioninclassification.pyanddashboard.py. No logic changes.The classification cache data keys (
thread_action,thread_id,thread_kind,thread_facts) are intentionally left unchanged here, so the restored classification cache is not invalidated and no reclassification is triggered. Those data keys are renamed in the follow-up feature PR (#78), which changes the cache key anyway.Split out from #78 to keep that PR's feature diff focused.