Skip to content

src: use DCHECK in AsyncWrap::MakeCallback instead emiting a warning #62795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Flarna wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: use DCHECK in AsyncWrap::MakeCallback instead emiting a warning #62795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/async_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@
#include "env-inl.h"
#include "node_errors.h"
#include "node_external_reference.h"
#ifdef DEBUG
#include <node_process-inl.h>
#endif
#include "tracing/traced_value.h"
#include "util-inl.h"

Expand Down Expand Up @@ -677,13 +674,8 @@ MaybeLocal<Value> AsyncWrap::MakeCallback(const Local<Function> cb,
Local<Value>* argv) {
EmitTraceEventBefore();

#ifdef DEBUG
if (context_frame().IsEmpty()) {
ProcessEmitWarning(env(),
"MakeCallback() called without context_frame, "
"likely use after destroy of AsyncWrap.");
}
#endif
// If this check fails it indicates an use after-free.
DCHECK(!context_frame().IsEmpty());

ProviderType provider = provider_type();
async_context context { get_async_id(), get_trigger_async_id() };
Expand Down
Loading