src: use DCHECK in AsyncWrap::MakeCallback instead emiting a warning#62795
Open
Flarna wants to merge 1 commit intonodejs:mainfrom
Open
src: use DCHECK in AsyncWrap::MakeCallback instead emiting a warning#62795Flarna wants to merge 1 commit intonodejs:mainfrom
Flarna wants to merge 1 commit intonodejs:mainfrom
Conversation
Replace emitting of a process warning by a DCHECK because the use after free in http parser is fixed now. Refs: nodejs#61995 (comment) Refs: nodejs#62095
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62795 +/- ##
==========================================
- Coverage 89.69% 89.68% -0.02%
==========================================
Files 706 706
Lines 218270 218270
Branches 41781 41778 -3
==========================================
- Hits 195772 195746 -26
- Misses 14398 14437 +39
+ Partials 8100 8087 -13
🚀 New features to boost your workflow:
|
Flarna
added
the
author ready
addaleax
approved these changes
Apr 18, 2026
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Flarna
added
async_hooks
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/62795 ✔ Done loading data for nodejs/node/pull/62795 ----------------------------------- PR info ------------------------------------ Title src: use DCHECK in AsyncWrap::MakeCallback instead emiting a warning (#62795) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Flarna:async_wrap_dcheck -> nodejs:main Labels c++, async_hooks, author ready, needs-ci, dont-land-on-v20.x Commits 1 - src: use DCHECK in AsyncWrap::MakeCallback instead emiting a warning Committers 1 - Gerhard Stöbich <18708370+Flarna@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/62795 Refs: https://github.com/nodejs/node/pull/62095 Reviewed-By: Anna Henningsen <anna@addaleax.net> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62795 Refs: https://github.com/nodejs/node/pull/62095 Reviewed-By: Anna Henningsen <anna@addaleax.net> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 17 Apr 2026 20:52:55 GMT ✔ Approvals: 1 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/62795#pullrequestreview-4135136774 ✘ This PR needs to wait 120 more hours to land (or 0 minutes if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-04-19T06:18:40Z: https://ci.nodejs.org/job/node-test-pull-request/72780/ - Querying data for job/node-test-pull-request/72780/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/24639127204 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace emitting of a process warning by a DCHECK because the use after free in http parser is fixed now.
Refs: #61995 (comment)
Refs: #62095