updated test evaluation strategy - check for getReadsMD5, instead of getREADs using the nf-bam plugin to avoid linting conflicts.#12348
Open
Kevin-Brockers wants to merge 14 commits into
Conversation
…ds directly to avoid merge marker conflicts during linting
…onda GetReadMd5 resulted in unstable hashes between my local and the github CI tests
…rMD5, fall back strategy -> Test if file exists and get just the alignment statistics for bam files
nvnieuwk
reviewed
Jul 13, 2026
| @@ -549,7 +477,8 @@ nextflow_process { | |||
| { assert process.success }, | |||
| { assert snapshot( | |||
| file(process.out.cram[0][1]).name, | |||
Contributor
There was a problem hiding this comment.
Same here for the statistics
Contributor
Author
There was a problem hiding this comment.
I hope this is sufficient? I don't necessary like the hardcoded path but file(params.modules_testdata_base_path +
'genomics/sarscov2/genome/genome.fasta') gave an error... so I hard coded it, similar as in other modules.
Contributor
There was a problem hiding this comment.
You could add the fasta file string to the meta map and fetch it from there in the test output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ds directly to avoid merge marker conflicts during linting
PR checklist
close #12289
Closes #XXX
nf-core modules test <MODULE> --profile docker