New module: GRIMER#11663
Conversation
|
The stub test now uses an existing nf-core/test-datasets file to pass CI. I hope to add in a proper GRIMER-specific count table TSV to nf-core/test-datasets in a follow-up post-PR after review |
There was a problem hiding this comment.
Can you create this file on-the-fly within the nf.test please.
| pattern: "*.tsv" | ||
| ontologies: | ||
| - edam: http://edamontology.org/format_3475 | ||
| - meta3: |
There was a problem hiding this comment.
Call this config or something similar
There was a problem hiding this comment.
Thanks for the review @SPPearce! You're definitely right with the meta3 / config naming. I will rename to config since it's a pipeline-level file not tied to individual samples, and restructure as a plain path input without a meta map wrapper
| pass [] to omit. | ||
| pattern: "*.tsv" | ||
| ontologies: | ||
| - edam: http://edamontology.org/format_3475 |
There was a problem hiding this comment.
We use meta, meta2, meta3 to mean Nextflow meta maps, not csv file metadata.
Are these files actually sample dependent? Because if so it should be part of the initial tuple.
There was a problem hiding this comment.
Thanks for the review and comments, I'll address them
There was a problem hiding this comment.
Not sure what is going on with this file, but I don't think you should be changing it.
There was a problem hiding this comment.
This file was actually modified automatically by nf-core modules lint when it prompted for repository type on first run. I Will revert it to its original state and exclude it from the PR
| then { | ||
| assertAll( | ||
| { assert process.success }, | ||
| { assert process.out.report } |
There was a problem hiding this comment.
This should be the snapshot of the outputs.
There was a problem hiding this comment.
Thanks for the comment, I'll replace { assert process.out.report } with { assert snapshot(process.out).match() } and produce another output snapshot
…add stub snapshot, revert .nf-core.yml
…meta.yml, update tests
|
Thanks for the latest comments @SPPearce! I've gone through everything and pushed some fixe *The metadata input in main.nf was tripping the linter since anything prefixed with meta gets treated as a Groovy map and renamed it to sample_metadata and that cleared it up |
|
Managed to fix the two GRIMER-specific CI failures in the latest push: *Version eval: The remaining CI failures ( |
|
The confirm-pass-lint gate failure is downstream of the multiqc and multiqcsav lint failures, which seems like pre-existing issues in those modules unrelated to this PR. The GRIMER module lint passes cleanly. I'm happy to have a reviewer confirm it |
Closes #11566
Description
Adds a new nf-core module for GRIMER (v1.1.0), a tool that generates interactive HTML dashboards for contamination detection in metagenomics and viromics datasets.
Developed during the May 2026 nf-core x VirJenDB Virus Bioinformatics Hackathon.
Checklist
environment.ymlmatches bioconda packagemain.nfpasses lint (47/47 tests passed)meta.ymlcomplete and schema-valid