Skip to content

Amulety modules bump versions#11645

Merged
mashehu merged 42 commits into
nf-core:masterfrom
ggabernet:amulety
May 21, 2026
Merged

Amulety modules bump versions#11645
mashehu merged 42 commits into
nf-core:masterfrom
ggabernet:amulety

Conversation

@ggabernet
Copy link
Copy Markdown
Member

  • update amulety version
  • update snapshot

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Comment thread modules/nf-core/amulety/embed/environment.yml
Comment thread modules/nf-core/amulety/embed/environment.yml
@ggabernet
Copy link
Copy Markdown
Member Author

@mashehu thanks for the review, I'll address your points!

I also saw that the tests failed due to no space left in the runner, even though the new container seemed to be smaller than the previous one so that's a bit puzzling. Can something be done like increasing the runners size for this specific module test?

@ggabernet ggabernet requested review from a team as code owners May 19, 2026 19:02
Copy link
Copy Markdown
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do the same for the gpu test

Comment thread .github/workflows/nf-test.yml Outdated
Comment thread .github/workflows/nf-test.yml
@ggabernet ggabernet requested a review from mashehu May 20, 2026 17:28
@ggabernet
Copy link
Copy Markdown
Member Author

@mashehu thanks for the review, I've implemented the suggested changes. I needed 50GB for this modules test to run due to the size of the container, would it be fine to increase the size of the runners to that?

@mashehu
Copy link
Copy Markdown
Contributor

mashehu commented May 20, 2026

hmm, can you bump it up to get one passing run and then bump it down to the default. just don't want to waste too much resources for all the different tests we run. I can force merge the PR once you have one commit with ✅

@ggabernet
Copy link
Copy Markdown
Member Author

ggabernet commented May 21, 2026

@mashehu, thank you all tests pass now, so I'll bump it down to 40gb which was the previous default

@mashehu mashehu merged commit e86b866 into nf-core:master May 21, 2026
72 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants