New module: octopusv/merge#11617
Conversation
ea06d22 to
f83dbf8
Compare
9e5186c to
740d4da
Compare
|
You can put the valid list back into the module code if you like |
Pull request was closed
|
You can put the valid list back into the module code if you like |
|
(sorry, just accidentally closed the PR!) |
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
|
I was thinking of adding this: But I think it is fine as is, since some flags also require an INT or a string after. For such cases one needs to refer to the tool documentation anyway. Do you think I should add this? |
SPPearce
left a comment
There was a problem hiding this comment.
Ok, particularly if some strategies require an extra value as well, validation isn't as simple.
I'm happy as is.
|
Cool thanks, I added an optional output (an upset plot) which I found later on. and bumped the version to |
* Add octopusv/merge module * test-data path fix * fix versioning * add test data and update default merging logic * update merge flag * update tests * nextflow lint fixes + test update * Adress review feedback * minor change in meta.yml * Update modules/nf-core/octopusv/merge/meta.yml Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com> * Update modules/nf-core/octopusv/merge/main.nf Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com> * Update modules/nf-core/octopusv/merge/main.nf Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com> * Update modules/nf-core/octopusv/merge/main.nf Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com> * minor changes to test * remove edam for bgzip, add note to strategy_flag (meta.yml) * bump version + add upset plot output --------- Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
PR checklist
Closes #11516
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda