Skip to content

fix(files_reminders): keep batch alive on per-row failure #60713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
solracsf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(files_reminders): keep batch alive on per-row failure #60713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions apps/files_reminders/lib/BackgroundJob/ScheduledNotifications.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@

use OCA\FilesReminders\Db\ReminderMapper;
use OCA\FilesReminders\Service\ReminderService;
use OCP\AppFramework\Db\DoesNotExistException;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\BackgroundJob\TimedJob;
use Psr\Log\LoggerInterface;
use Throwable;

class ScheduledNotifications extends TimedJob {
public function __construct(
Expand All @@ -37,8 +37,11 @@ public function run($argument) {
foreach ($reminders as $reminder) {
try {
$this->reminderService->send($reminder);
} catch (DoesNotExistException $e) {
$this->logger->debug('Could not send notification for reminder with id ' . $reminder->getId());
} catch (Throwable $e) {
// A single broken reminder (e.g. orphaned user record) must not
// stall the rest of the queue, which is ordered by due_date ASC
// and would otherwise re-hit the same row on every cron tick.
$this->logger->error('Could not send notification for reminder with id ' . $reminder->getId(), ['exception' => $e]);
}
}
}
Expand Down
Loading