Skip to content

fix(files_reminders): keep batch alive on per-row failure#60713

Open
solracsf wants to merge 1 commit into
masterfrom
fix/F3-scheduled-notifications-throwable
Open

fix(files_reminders): keep batch alive on per-row failure#60713
solracsf wants to merge 1 commit into
masterfrom
fix/F3-scheduled-notifications-throwable

Conversation

@solracsf
Copy link
Copy Markdown
Member

Summary

The job iterates overdue reminders ordered by due_date ASC and only caught DoesNotExistException. A UserNotFoundException (thrown by ReminderService::send when the recipient user record is missing, e.g.: an orphaned LDAP user that was removed without firing UserDeletedEvent) or any other Throwable escaped the foreach, terminating the whole batch.

Because findOverdue re-pulls the same oldest row on every cron tick, this stalled the entire reminder pipeline indefinitely.

Catch Throwable, log at error level, and continue to the next reminder.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf added this to the Nextcloud 35 milestone May 24, 2026
@solracsf solracsf requested a review from a team as a code owner May 24, 2026 15:13
@solracsf solracsf requested review from Altahrim, ArtificialOwl, CarlSchwan and salmart-dev and removed request for a team May 24, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant