feat(codex): add Tauri commands and multi-account refresh lanes (PR 2/5) - #256
Conversation
|
Thanks for the PR, I will review this ASAP. |
|
Thermo-nuclear review (2/5 — shell): approve on structure once #255's ADR lands. The command surface is disciplined: Two nits: (a) the per-account lane borrows the ambient refresh interval — fine for now, but the ADR should say whether lanes co-own |
Wire the ADR 0003 domain into the shell: Tauri commands for account list/add/remove/switch/fetch/snapshots/restart-desktop, plus a parallel per-account refresh lane for Codex bounded by the shared fetch semaphore.
1cbf01e to
ae33fb1
Compare
Summary
commands/codex_accounts.rs: Tauri commands for account list/add/remove/switch/fetch/snapshots + restart Codex Desktop, registered inmain.rs.Related issue
ADR 0003 (
docs/adr/0003-multi-account-codex.md). No issue number yet.Affected areas
Validation
Hosted PR check runs on Blacksmith Windows when
CI_BUDGET_MODEis notoff(see.github/workflows/pr-check.ymlandCONTEXT.md). Still run the local slice and list commands/results below. If a check is not relevant, say why.powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\local-check.ps1powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\local-check.ps1 -All -Version <version>powershell.exe -File scripts\windows-release-build.ps1 -Ref <ref> -SmokeInstallcargo build --manifest-path apps/desktop-tauri/src-tauri/Cargo.tomlOK; 2 command unit tests passUI / tray proof
For UI, tray, settings, or visual behavior changes, use CUA Driver for visual proof. If CUA Driver cannot be used, explain why and attach equivalent manual proof.
Notes for reviewers
maincurrently shows both; after feat(codex): port multi-account Codex domain core (PR 1/5) #255 merges it will be rebased ontomainand show only this slice.providers.rskeeps the ambient "codex" snapshot for tray/menu unchanged; lanes only fill the account snapshot store for the Settings panel.Chain Context
main(rebase after #255 merges)#255merged stateChain Overview
Scope
commands/codex_accounts.rs, command registration (main.rs,commands/mod.rs), multi-lane refresh (providers.rs),CODEX_ACCOUNTS_UPDATEDevent (events.rs).Autonomy
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.