Skip to content

feat(codex): add Codex accounts panel in provider settings (PR 4/5) - #259

Merged
Finesssee merged 1 commit into
nesszer:mainfrom
BlazzzPlay:feat/codex-account-settings-panel
Aug 6, 2026
Merged

feat(codex): add Codex accounts panel in provider settings (PR 4/5)#259
Finesssee merged 1 commit into
nesszer:mainfrom
BlazzzPlay:feat/codex-account-settings-panel

Conversation

@BlazzzPlay

@BlazzzPlay BlazzzPlay commented Aug 5, 2026

Copy link
Copy Markdown

Summary

  • Add the ADR 0003 accounts panel inside the Codex provider detail pane (Settings → Providers → Codex).
  • CodexAccountsSection lists accounts (ambient + managed) with per-account usage bars, and exposes add / switch / fetch / remove / restart-desktop actions wired to the bridge commands.
  • Adds the panel styles to styles.css (menu/tray styles land in PR 5/5) and mounts the section in ProviderDetailPane.

Related issue

ADR 0003 (docs/adr/0003-multi-account-codex.md). No issue number yet.

Affected areas

  • Tray panel
  • Settings UI
  • Config file / settings persistence
  • Provider-specific behavior (Codex accounts panel)
  • Installer / release packaging
  • Startup / background behavior
  • Documentation
  • Other:

Validation

Hosted PR check runs on Blacksmith Windows when CI_BUDGET_MODE is not off (see .github/workflows/pr-check.yml and CONTEXT.md). Still run the local slice and list commands/results below. If a check is not relevant, say why.

  • powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\local-check.ps1
  • For full pre-release validation: powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\local-check.ps1 -All -Version <version>
  • For installer/release changes: powershell.exe -File scripts\windows-release-build.ps1 -Ref <ref> -SmokeInstall
  • Thermo-nuclear code quality review completed before submitting: https://github.com/cursor/plugins/blob/main/cursor-team-kit/skills/thermo-nuclear-code-quality-review/SKILL.md
  • Other: pnpm test CodexAccountsSection (4 tests) pass

UI / tray proof

For UI, tray, settings, or visual behavior changes, use CUA Driver for visual proof. If CUA Driver cannot be used, explain why and attach equivalent manual proof.

  • Not applicable
  • CUA Driver visual proof attached
  • CUA Driver could not be used; equivalent manual proof and explanation attached — settings panel rendering validated via unit tests (jsdom); CUA proof pending on a Windows host (AGENTS.md: MSIX/WebView2 paths require Windows-native validation). Will attach CUA proof in follow-up if requested.

Notes for reviewers

Chain Context

Field Value
Chain codex-multi-account (ADR 0003)
Tracker PR Not needed (stacked PRs to main)
Position 4 of 5
Base main (rebase after #258 merges)
Depends on #258 (frontend bridge + i18n)
Follow-up #5 tray menu flyout
Review budget 485 / 400 (marginal size:exception)
Starts at #258 merged state
Ends with Codex accounts panel renders in Settings → Providers with add/switch/fetch/remove actions

Chain Overview

main
 ├── #255 domain core — reviewed
 ├── #256 shell commands + lanes — reviewed
 ├── #258 frontend bridge + i18n — reviewed
 └── 📍 #4 This PR — settings accounts panel
      └── #5 tray menu flyout

Scope

  • Includes: CodexAccountsSection.tsx (+ test), mount in ProviderDetailPane.tsx, panel styles in styles.css.
  • Excludes: tray/menu flyout component and its styles — PR 5/5.

Autonomy

  • CI is expected to pass for this PR branch
  • This PR has one deliverable scope
  • This PR can be rolled back without unrelated changes
  • Tests cover this unit (4 jsdom tests)

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@Finesssee

Copy link
Copy Markdown
Collaborator

Thanks for the PR, I will review this ASAP.

@Finesssee

Copy link
Copy Markdown
Collaborator

Thermo-nuclear review (4/5 — settings panel): approve pending maintainer-run CUA proof.

The section follows the existing settings-section grammar (Field/Toggle/form rows, i18n keys via t()), mounts inside the Codex provider detail dispatch only where the Codex provider lives — correct scoping, no shared-path conditionals. The ambient-vs-managed account split in list rendering matches the domain model from #255.

Process: per repo AGENTS.md, settings-UI changes build CUA-driven proof after a fresh local rebuild — that's a maintainer-side artifact (contributors can't run our CUA). We'll take that on at merge time (same model as the notification-sounds PR in #251). Nothing blocked on you; landing both #255 items first applies.

Render the ADR 0003 accounts panel inside the Codex provider detail pane:
list accounts with usage bars, add/switch/fetch/remove actions, and the
restart-desktop affordance, plus its dedicated styles.
@Finesssee
Finesssee force-pushed the feat/codex-account-settings-panel branch from 58d1f1f to 468fa8c Compare August 6, 2026 06:37
@Finesssee
Finesssee merged commit dc1fabd into nesszer:main Aug 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants