Update Dear ImGui to v1.91#113
Conversation
|
So what's the actual reason to push this? Are there any new features you really need? |
|
The big one for me is the feature-rich tables API. Very powerful for creating monitors and control panels for lots of elements/devices/agents etc. The previous columns API was rather clunky. There are also options to view-clip large lists. Other than that I've been inconvenienced more frequently by small quirks and issues that were addressed in later versions. |
|
Thanks for the clarification, makes sense; I'm currently working on a lot of GUI specific code, probably good to merge this change into NAP and use that as a base instead of our current version of |
This reverts commit 7f0be57.
|
Trying your version, noticed that icons are rendered incorrect: yours: 
current: 
|
| ImGui::PlotHistogram("Histogram", mPlotvalues.data(), mPlotvalues.size(), mTickIdx, nullptr, 0.0f, 0.2f, ImVec2(ImGui::GetColumnWidth(), 128)); // Plot the output values | ||
| ImGui::SliderFloat("Filter Frequency", &mAnalysisFrequency, 0.0f, 10000.0f, "%.3f", 2.0f); | ||
| ImGui::SliderFloat("Filter Bandwidth", &mAnalysisBand, 1.f, 10000.0f, "%.3f", 2.0f); | ||
| ImGui::SliderFloat("Filter Frequency", &mAnalysisFrequency, 0.0f, 10000.0f, "%.3f", ImGuiSliderFlags_Logarithmic); |
There was a problem hiding this comment.
Can we maybe find a backwards compatible way of dealing with this, that doesn't break current client side code? An override in imconfig.h would be appropiate (included by imgui.h)
|
|
||
| if (frame_padding >= 0) | ||
| ImGui::PushStyleVar(ImGuiStyleVar_FramePadding, ImVec2((float)frame_padding, (float)frame_padding)); | ||
| bool clicked = ImGui::ImageButton(icon.mID.c_str(), gui_service->getTextureHandle(icon.getTexture()), size, { 0, 1 }, { 1, 0 }, bg_col, tint_col); |
There was a problem hiding this comment.
See comment, for some reason the button doesn't render correct (transparency issue?).
| { | ||
| ImGui::PushItemWidth(145.0f * mState.mScale); | ||
| ImGui::InputFloat2("", &v[0], precision); | ||
| const auto format = "%." + std::to_string(precision) + "f"; |
There was a problem hiding this comment.
Consider turning precision into a constexpr, it's normally known at compile time.
2 participants
napimguiandnap::ImGuiServiceto deal with the increased responsibility over input management on the ImGui side.There are a few breaking changes in the ImGui API, but they are well documented. Instances of commonly used functions include:
ImGui::SliderFloatImGui::InputFloatImGui::GetKeyIndex