Skip to content

Give the SyncedTabsAdapter.getItemViewType() when subject a non-null type #4563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonalmeida merged 2 commits into from
Sep 23, 2026
Merged

Give the SyncedTabsAdapter.getItemViewType() when subject a non-null type #4563

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf5966e
Give the SyncedTabsAdapter.getItemViewType() when subject a non-null …
rvandermeulen Sep 23, 2026
46f43dc
Merge branch 'master' into synced-tabs-when-null
mergify[bot] Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/src/main/java/org/mozilla/reference/browser/tabs/synced/SyncedTabsAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,13 @@ class SyncedTabsAdapter(private val listener: (SyncTab) -> Unit) :
holder.bind(item, listener)
}

override fun getItemViewType(position: Int): Int =
when (getItem(position)) {
override fun getItemViewType(position: Int): Int {
val item: AdapterItem = getItem(position)
return when (item) {
is AdapterItem.Device -> DeviceViewHolder.LAYOUT_ID
is AdapterItem.Tab -> TabViewHolder.LAYOUT_ID
}
}

private object DiffCallback : DiffUtil.ItemCallback<AdapterItem>() {
override fun areItemsTheSame(
Expand Down
Loading