Give the SyncedTabsAdapter.getItemViewType() when subject a non-null type - #4563
Open
rvandermeulen wants to merge 1 commit into
Open
rvandermeulen wants to merge 1 commit into
rvandermeulen wants to merge 1 commit into
Conversation
…type. Kotlin 2.5 warns that the platform-typed getItem() result is unhandled when null, which -Werror turns into a build failure.
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kotlin 2.5 warns that the platform-typed
getItem()result is unhandled when null, which-Werrorturns into a build failure. Typing the subject as non-null fixes it without a!!(detekt's UnsafeCallOnNullableType) and builds cleanly on the current Kotlin 2.4.20.