Onboard testfx to MSBuildCache with PR canary#10090
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 89fbe5c4-a15f-4f65-8a32-6b2dabfe8e74
Contributor
There was a problem hiding this comment.
Pull request overview
Adds opt-in MSBuildCache support and a non-blocking Windows PR canary while retaining the Arcade build.
Changes:
- Configures local and Azure Pipelines cache backends.
- Adds a clean static-graph cache build script.
- Integrates and documents the Windows PR canary.
Show a summary per file
| File | Description |
|---|---|
NuGet.config |
Adds the restricted cache package source. |
Directory.Build.props |
Defines opt-in cache settings. |
Directory.Packages.props |
Adds cache build dependencies. |
azure-pipelines.yml |
Runs the Windows PR cache canary. |
eng/build-msbuild-cache.ps1 |
Implements cache-aware graph builds. |
eng/install-access-database-engine.ps1 |
Moves installer staging to temporary storage. |
docs/dev-guide.md |
Documents local cache validation. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 3
- Review effort level: Medium
Use Arcade's MSBuild launcher for the cache canary, isolate token-bearing logs, and clean all canary outputs before the authoritative build. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 89fbe5c4-a15f-4f65-8a32-6b2dabfe8e74
Evangelink
enabled auto-merge (squash)
July 21, 2026 07:02
0101
approved these changes
Jul 21, 2026
Avoid immutable Azure Pipeline cache write collisions and keep canary failures non-blocking for required PR validation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 89fbe5c4-a15f-4f65-8a32-6b2dabfe8e74
0101
approved these changes
Jul 21, 2026
Keep PR consumers read-only, reliably isolate canary failures, and serialize TFM-independent package layout copies. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 89fbe5c4-a15f-4f65-8a32-6b2dabfe8e74
0101
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eng/common/msbuild.ps1launcher for a direct Windows static-graph build because Arcade's outerBuild.projcannot expose the repository graph to the project-cache pluginmainruns to seed refreshed remote cache entriesValidation
TestFx.slnxRelease cold build: 204 nodes, 204 misses, 0 errorsTestFx.slnxRelease warm build: 204 nodes, 204 hits, 100% hit ratio, 57.1 project-minutes savedMicrosoft.Testing.Platform.MSBuild12-node graph passed three consecutive/graph /m /t:Rebuildruns with zero warnings/errorsCacheClient.logStart-Processcaptures a simulated child exit 42 while the canary wrapper returns successmainruns can seed themgit diff --checkpassedOfficial publishing builds remain unchanged while the public PR canary gathers rollout data.