Stop MSBuildCache canary warning escalation#10109
Open
Evangelink wants to merge 1 commit into
Open
Conversation
Keep expected uncoded MSBuildCache warnings from appearing as errors while leaving the authoritative Arcade build strict. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: e3ba5312-a54a-415d-904f-421091599e5b
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents expected MSBuildCache canary warnings from failing the experimental build while preserving the strict authoritative Arcade fallback.
Changes:
- Disables Arcade’s default warning escalation for the cache canary.
- Removes the redundant MSBuild
/warnaserrorargument.
Show a summary per file
| File | Description |
|---|---|
azure-pipelines.yml |
Configures the cache canary to run without warning escalation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
Evangelink
enabled auto-merge (squash)
July 21, 2026 13:27
0101
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #10090 after Azure build 1519505.
The Windows cache canary reported expected
AllowFileAccessAfterProjectFinishFilePatternsmatches forINetCache/dyntelconfigas errors. MSBuildCache emits these allowlisted accesses as uncoded warnings, so MSBuild's code-specific warning controls cannot target them. Arcade'seng/common/msbuild.ps1also enables warning escalation by default.This change explicitly passes
-warnAsError:$falseto the experimental cache canary and removes its redundant/warnaserrorargument. The authoritative Arcade fallback build remains unchanged and strict.Validation
azure-pipelines.ymlwith PyYAML-warnAsError:$false/warnaserroreng\common\CIBuild.cmdfallback remains presentazure-pipelines.ymlchangedgit diff --checkpassed