Skip to content

chore: keep maintainer PRs draft through validation (Fixes #491) - #492

Merged
Karthik Nadig (karthiknadig) merged 1 commit into
mainfrom
chore/issue-491
Jul 28, 2026
Merged

chore: keep maintainer PRs draft through validation (Fixes #491)#492
Karthik Nadig (karthiknadig) merged 1 commit into
mainfrom
chore/issue-491

Conversation

@karthiknadig

Copy link
Copy Markdown
Member

Summary

  • keep maintainer-created PRs draft through Copilot review and review fixes
  • require CI and quality snapshot inspection before transitioning to ready
  • mark ready only immediately before merge or auto-merge

Fixes #491

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

Performance Report (Linux) ➖

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 0ms 1ms 1ms -1ms -100.0%
Full Refresh 46ms 935ms 45ms 1ms 0%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

Test Coverage Report (Linux)

Metric Value
Current Coverage 80.4%
Base Branch Coverage 80.4%
Delta 0% ➖

Coverage unchanged.

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

Performance Report (macOS)

Metric PR (P50) PR (P95) Baseline (P50) Delta
Server Startup 73ms 669ms 82ms -9ms
Full Refresh 133ms 30198ms 153ms -20ms

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

Performance Report (Windows) ➖

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 8ms 11ms 8ms 0ms 0%
Full Refresh 147ms 1214ms 137ms 10ms 7.3%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

Test Coverage Report (Windows)

Metric Value
Current Coverage 77.19%
Base Branch Coverage 77.19%
Delta 0% ➖

Coverage unchanged.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the maintainer workflow documentation to explicitly keep maintainer-created PRs in draft status through Copilot review, addressing feedback, CI, and quality snapshot inspection, and only transition to ready immediately before merge or enabling auto-merge (Fixes #491).

Changes:

  • Clarifies that maintainer-created PRs must remain draft during review/iteration and validation phases.
  • Adds an explicit “Mark the PR ready” step immediately before merge/auto-merge, after checks and quality snapshot review are acceptable.
  • Renumbers the Merge & Cleanup checklist to accommodate the new readiness-transition step.
Show a summary per file
File Description
.github/agents/Maintainer.agent.md Clarifies draft-to-ready timing in the maintainer PR lifecycle and tightens merge prerequisites wording.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Low

@karthiknadig
Karthik Nadig (karthiknadig) marked this pull request as ready for review July 28, 2026 15:31
@karthiknadig
Karthik Nadig (karthiknadig) merged commit b618197 into main Jul 28, 2026
38 checks passed
@karthiknadig
Karthik Nadig (karthiknadig) deleted the chore/issue-491 branch July 28, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify draft PR lifecycle in maintainer workflow

3 participants