Problem
Recent PET PRs repeatedly received review feedback for gaps not covered by the current Rust locator skill and reviewer checklist: normalized cache keys and value identity, Unicode-safe byte indexing, tests that directly prove performance invariants, recursive-glob semantics, duplicate side effects, and GitHub workflow postcondition verification.
Scope
Review feedback from PRs #484, #486, #487, #490, #492, #493, #494, and #495, then update repository Rust coding and reviewer guidance with reusable PET-specific rules.
Acceptance criteria
- Capture recurring Rust findings with concrete good/bad examples.
- Add reviewer checks for path-key normalization, Unicode-safe parsing, hot-path allocations/I/O, duplicate side effects, and behavioral regression tests.
- Keep repository-specific architecture and workflow guidance separate from irrelevant rules in external source material.
- Avoid duplicating existing locator-order and pre-commit guidance.
Problem
Recent PET PRs repeatedly received review feedback for gaps not covered by the current Rust locator skill and reviewer checklist: normalized cache keys and value identity, Unicode-safe byte indexing, tests that directly prove performance invariants, recursive-glob semantics, duplicate side effects, and GitHub workflow postcondition verification.
Scope
Review feedback from PRs #484, #486, #487, #490, #492, #493, #494, and #495, then update repository Rust coding and reviewer guidance with reusable PET-specific rules.
Acceptance criteria